Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751662AbdHGOhu (ORCPT ); Mon, 7 Aug 2017 10:37:50 -0400 Received: from resqmta-po-07v.sys.comcast.net ([96.114.154.166]:35484 "EHLO resqmta-po-07v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247AbdHGOht (ORCPT ); Mon, 7 Aug 2017 10:37:49 -0400 Date: Mon, 7 Aug 2017 09:37:46 -0500 (CDT) From: Christopher Lameter X-X-Sender: cl@nuc-kabylake To: Laura Abbott cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kees Cook , Rik van Riel Subject: Re: [RFC][PATCH] mm/slub.c: Allow poisoning to use the fast path In-Reply-To: <20170804231002.20362-1-labbott@redhat.com> Message-ID: References: <20170804231002.20362-1-labbott@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CMAE-Envelope: MS4wfFbxFlCkbAbyrJIUCjsdVba4XRzEbW6A3EZIcjBQOhpGmdZtfnN78qAWOzcAFjb+k3i1wnoGj3rQv5MInkhlvG91swVqbKyRx9aN1m/fcdQtVKybWqrZ Y5kogOskeYvn1hTZ0lEvi8D7Mx0kqv+t8F2/WefADobRQ1kHd9ZnMCoc//ypeuaUUcb3QKVAroUHGduVpRfP5wKCR+1qoqYeIhAPNmrPT+T3UhCXo2fAP57K TxcK82m4oq9CK47L44gHOSRWan3XxCWWsiHs7U7xQ4CGkZ5FJ8sfvBnwWD4l/a29vz1iVhteTupreRNDR98iSwYGl8r7FtxnBm1azOG/GYX0jk+tG+hI0Tph zpHHfEbh7XTIdlsjpyrgGfRmXafVkIxiBatrzdQj11LKJ/bOmDo4mxFmzgotTKTfIMHwqqpN Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 712 Lines: 14 On Fri, 4 Aug 2017, Laura Abbott wrote: > All slub debug features currently disable the fast path completely. > Some features such as consistency checks require this to allow taking of > locks. Poisoning and red zoning don't require this and can safely use > the per-cpu fast path. Introduce a Kconfig to continue to use the fast > path when 'fast' debugging options are enabled. The code will > automatically revert to always using the slow path when 'slow' options > are enabled. Ok I see that the objects are initialized with poisoning and redzoning but I do not see that there is fastpath code to actually check the values before the object is reinitialized. Is that intentional or am I missing something?