Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751876AbdHGO5l (ORCPT ); Mon, 7 Aug 2017 10:57:41 -0400 Received: from g9t5008.houston.hpe.com ([15.241.48.72]:47182 "EHLO g9t5008.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbdHGO5j (ORCPT ); Mon, 7 Aug 2017 10:57:39 -0400 From: "Kani, Toshimitsu" To: "bp@alien8.de" CC: "linux-acpi@vger.kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "tony.luck@intel.com" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "rjw@rjwysocki.net" Subject: Re: [PATCH v2 7/7] edac drivers: add MC owner check in init Thread-Topic: [PATCH v2 7/7] edac drivers: add MC owner check in init Thread-Index: AQHTDKUAfktjLOT49USn5fr8A7X0qaJz4Q0AgADZxwCAAIj7AIADuzqA Date: Mon, 7 Aug 2017 14:57:35 +0000 Message-ID: <1502117279.2042.130.camel@hpe.com> References: <20170803215753.30553-1-toshi.kani@hpe.com> <20170803215753.30553-8-toshi.kani@hpe.com> <20170804083922.GC15617@nazgul.tnic> <1501882730.2042.123.camel@hpe.com> <20170805054906.GF23214@nazgul.tnic> In-Reply-To: <20170805054906.GF23214@nazgul.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.219.163.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DF4PR84MB0188;6:lsTo3K1xbVylJdS+uVYUeKxGWD+AroyEzV6l59DNi96/jJ3SNCKrBNTJhe/PxpfuvQrsHqAEtI0zktNoX/izWECffl9wOt/p2cWZ9e7HLnfUIxiUQyH6fMVB0mMR4NuxSEmzwCnL4wTWDzWhOOsXboeSFeVa5Dwytf0wdzfoEV1tKi8fykZdmzUnJX0XuV6scnjcnncM9CJ5y9yj79G73Ivm1f0SBL6JkQXxGcW9hoMf+EB1RwYTG2jOffGLZTfJ1vy8JtwNSPZcu6L6/U89dERJ+xBKryv/JombWXIpB5xsVw8c/DAtECrbyScAYKkZdiA4KchOf561pRp5lx5peQ==;5:twQjKpw2AptivTUn0fel0T8PWMDa8WLQaqqLhqH2aDZ6q+/23HuN2NsLPELT0xf3sYXj3dxRZOJpXYoEhB84QWe98EMEhNL0OhHCK3eGhZjjH7JCMb0ja+N/cqQ2cgG3JHaxIXaySGL6CGWxVjO2Jw==;24:cQ/YpY43SdTomdjzyX7yOpaAnXxZbPA9xFBlZolRpfdc3A+JXZefysULn8JtusIeKTaoqibCvv0W3+0oIB01q3zl1iP70tnwtDs4bRcXjek=;7:9HvDdywIXPmoqHSE1CG4jFg0cWa1HASFOd7ySCo0qd9wvlOA9mhrBNj+5iA0YeypoJhlcbcsucGEAmD7BL4DaNeDv6Z231V4KXWSe5H1T7ErBdqqYQXNgE9LL0OZV3h66QhY4oJTA/vRC4YB+8f9Z2/eIvH8jj+4W0PS1c2XVC1ibo/j3DKAh1rgJBgS9qlKQDg9aGw6CEP0V7hOf0YyeA6QEWquE4JmhjOVrRgHZAU= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: dba9d6af-5fb1-4b8c-12c6-08d4dda4a3e2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DF4PR84MB0188; x-ms-traffictypediagnostic: DF4PR84MB0188: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123555025)(20161123560025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DF4PR84MB0188;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DF4PR84MB0188; x-forefront-prvs: 0392679D18 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39840400002)(39450400003)(39850400002)(39860400002)(39400400002)(39410400002)(24454002)(377424004)(189002)(199003)(33646002)(2950100002)(6916009)(103116003)(305945005)(7736002)(53936002)(38730400002)(2351001)(81156014)(81166006)(1730700003)(8676002)(3660700001)(478600001)(93886004)(86362001)(2906002)(3280700002)(14454004)(8936002)(6436002)(2900100001)(66066001)(4326008)(229853002)(50986999)(54906002)(101416001)(5640700003)(68736007)(5660300001)(54356999)(76176999)(25786009)(2501003)(6506006)(97736004)(6246003)(110136004)(3846002)(102836003)(6116002)(6512007)(77096006)(105586002)(106356001)(189998001)(6486002)(36756003);DIR:OUT;SFP:1102;SCL:1;SRVR:DF4PR84MB0188;H:DF4PR84MB0187.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <34EC165979CEB2498BDE72D4DA4142D3@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2017 14:57:35.8865 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0188 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v77EvmVQ013918 Content-Length: 605 Lines: 16 On Sat, 2017-08-05 at 07:49 +0200, Borislav Petkov wrote: > On Fri, Aug 04, 2017 at 09:48:23PM +0000, Kani, Toshimitsu wrote: > > Not sure if anyone cares, but I thought it should return with > > -ENODEV when this modules found no target, and -EBUSY when it found > > a target but it's busy.  Hence, this ordering. > > You can still return -EBUSY. Just do the owner check first because if > we're going to return due to ghes_edac being loaded already, we might > just as well skip the other checks as they're a pointless waste of > cycles and energy. Got it. Will move up the check. Thanks, -Toshi