Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752021AbdHGPB2 (ORCPT ); Mon, 7 Aug 2017 11:01:28 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:37688 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbdHGPB1 (ORCPT ); Mon, 7 Aug 2017 11:01:27 -0400 Date: Mon, 7 Aug 2017 17:01:23 +0200 From: Daniel Vetter To: David Lechner Cc: dri-devel@lists.freedesktop.org, Daniel Vetter , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] drm/fb-helper: pass physical dimensions to fbdev Message-ID: <20170807150123.gpxz4gwzam52aukk@phenom.ffwll.local> Mail-Followup-To: David Lechner , dri-devel@lists.freedesktop.org, Daniel Vetter , linux-kernel@vger.kernel.org References: <1501863924-7154-1-git-send-email-david@lechnology.com> <7916b6bd-cc6b-0696-4c78-5413389c600a@lechnology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7916b6bd-cc6b-0696-4c78-5413389c600a@lechnology.com> X-Operating-System: Linux phenom 4.11.0-2-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 620 Lines: 17 On Mon, Aug 07, 2017 at 08:40:35AM -0500, David Lechner wrote: > On 08/04/2017 11:25 AM, David Lechner wrote: > > The fbdev subsystem has a place for physical dimensions (width and height > > in mm) that is readable by userspace. Since DRM also knows these > > dimensions, pass this information to the fbdev device. > > > > This has to be done in drm_setup_crtcs_fb() instead of drm_setup_crtcs() > > because fb_helper->fbdev may be NULL in drm_setup_crtcs(). > > Signed-off-by: David Lechner Thanks, applied. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch