Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046AbdHGPLz (ORCPT ); Mon, 7 Aug 2017 11:11:55 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:52404 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbdHGPLx (ORCPT ); Mon, 7 Aug 2017 11:11:53 -0400 X-AuditID: b6c32a48-f79a16d00000362a-af-598883363caa From: Bartlomiej Zolnierkiewicz To: Arnd Bergmann Cc: Daniel Vetter , Dan Carpenter , Sean Paul , Arvind Yadav , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fbdev: matrox: hide unused 'hotplug' variable Date: Mon, 07 Aug 2017 17:11:48 +0200 Message-id: <3387426.dX5mCNm2tR@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170802093722.3666961-1-arnd@arndb.de> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJKsWRmVeSWpSXmKPExsWy7bCmma5Zc0ekwYejahZ/Jx1jt7jWu5DZ 4vW/6SwWCx/eZbY40feB1eLyrjlsFnc3nGV0YPf4/WsSo8fshossHnu/LWDx2DnrLrvHx6e3 WDw+b5ILYIvisklJzcksSy3St0vgyjhy/wBjwTOWir0Nd9kaGP8wdzFycEgImEhMmyPTxcgJ ZIpJXLi3nq2LkYtDSGAHo8TnhYtZIZzPjBKfTi1khagykVjw8TUjRGIto8SttTegqr4ySizd +YQRpIpNwEpiYvsqMFtEQFFi6otnzCBFzAKPGCUmHnzMBJIQFnCSmLHtO1gRi4CqxOY5B8Fs XgFNiQsvF7GA2KICXhJb9rWD1XMKmEpc7LzMBFEjKPFj8j2wGmYBeYl9+6eyQtg6EmePrQM7 T0JgHbtE26/fbBCPykpsOsAM8YKLxI8ZD6FsYYlXx7ewQ9hSEt0ds6Ds6YwS239LQMzZzCix avcEqIS1xOHjF6GW8Ul0HP7LDjGfV6KjTQiixEPi7NEX0OBylGhYvosJEkIdjBL/t/xmnMAo PwvJD7OQ/DALyQ8LGJlXMYqlFhTnpqcWGxWY6BUn5haX5qXrJefnbmIEJxgtjx2MB875HGIU 4GBU4uFdkdYRKcSaWFZcmXuIUYKDWUmEl7UJKMSbklhZlVqUH19UmpNafIhRmoNFSZy3btu1 CCGB9MSS1OzU1ILUIpgsEwenVAOjyPxPijLnP+bp/NYNDFlwvaOgw3VByv+Lu1+flnayfNE3 W22RVnCsVfJfKanlMdOlGf2XObl5Cv8zufG/9dnrxxO7182Zv3m65Z+NQuvOHr7q9PTk9Lbu A+0PvnE+rPx72Wx18fGuO9/SgyYJn7h5552iuYuY7xauGHPbpPU9ey/72jpeb5o4S4mlOCPR UIu5qDgRAFbVvlwsAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsVy+t9jQV2z5o5Ig337eCz+TjrGbnGtdyGz xet/01ksFj68y2xxou8Dq8XlXXPYLO5uOMvowO7x+9ckRo/ZDRdZPPZ+W8DisXPWXXaPj09v sXh83iQXwBblZpORmpiSWqSQmpecn5KZl26rFBripmuhpJCXmJtqqxSh6xsSpKRQlphTCuQZ GaABB+cA92AlfbsEt4wj9w8wFjxjqdjbcJetgfEPcxcjJ4eEgInEgo+vGSFsMYkL99azdTFy cQgJrGaU+Np/EiwhJPCVUeLdciEQm03ASmJi+yqwuIiAosTUF8+YQRqYBR4xSqy79poJJCEs 4CQxY9t3sCIWAVWJzXMOgtm8ApoSF14uYgGxRQW8JLbsawer5xQwlbjYeZkJYnMXo8T7hh/M EA2CEj8m3wNrYBaQl9i3fyorhK0lsX7ncaYJjAKzkJTNQlI2C0nZAkbmVYxiqQXFuem5xUYF RnrFibnFpXnpesn5uZsYgdG27bBWwA7GpnPRhxgFOBiVeHgZMjsihVgTy4orcw8xSnAwK4nw ZjUBhXhTEiurUovy44tKc1KLDzGaAv03kVlKNDkfmAjySuINTSyNTAzMzAyNDIzNlMR5JwR+ iRASSE8sSc1OTS1ILYLpY+LglGpgLNjnPrvEb9XjFkYX/uAn8g93bRS0rhJStmk2VjPti19h toi7pzhKpqjmf5j+96jpfaKP2lec5NjqUlCy/UXT2mdmSRdnCEm1XutUDX5jpWqxlLnCmv2V vffxvAtvHsxwL20+YbbiwJPJOzxqiq9v3qdu4z13unnW8rP/TTKLpWt3RFRvvi6jxFKckWio xVxUnAgALxRuyswCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170807151150epcas2p4ecce70ceabe29922223a26c60075ee50 X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 102P X-CMS-RootMailID: 20170802093751epcas3p4c7955b185ba3a2e39c230da58de3e9e0 X-RootMTR: 20170802093751epcas3p4c7955b185ba3a2e39c230da58de3e9e0 References: <20170802093722.3666961-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 593 Lines: 19 On Wednesday, August 02, 2017 11:36:47 AM Arnd Bergmann wrote: > The variable has become unused in modular configurations > which triggers a harmless warning: > > drivers/video/fbdev/matrox/matroxfb_base.c:1583:12: error: 'hotplug' defined but not used [-Werror=unused-variable] > > This moves it into an #ifdef section of the file, matching > all its references. > > Fixes: 376b3ff54c9a ("fbdev: Nuke FBINFO_MODULE") > Signed-off-by: Arnd Bergmann Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics