Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751826AbdHGPSK (ORCPT ); Mon, 7 Aug 2017 11:18:10 -0400 Received: from imap0.codethink.co.uk ([185.43.218.159]:41199 "EHLO imap0.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdHGPSI (ORCPT ); Mon, 7 Aug 2017 11:18:08 -0400 Message-ID: <1502119078.2047.23.camel@codethink.co.uk> Subject: Re: [PATCH 4.4 17/91] drm: rcar-du: Simplify and fix probe error handling From: Ben Hutchings To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Laurent Pinchart , thongsyho , Nhan Nguyen Date: Mon, 07 Aug 2017 16:17:58 +0100 In-Reply-To: <20170804231556.633658434@linuxfoundation.org> References: <20170804231555.678888089@linuxfoundation.org> <20170804231556.633658434@linuxfoundation.org> Organization: Codethink Ltd. Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 670 Lines: 27 On Fri, 2017-08-04 at 16:15 -0700, Greg Kroah-Hartman wrote: [...] > @@ -291,6 +290,15 @@ static int rcar_du_probe(struct platform > rcdu->dev = &pdev->dev; > rcdu->info = of_match_device(rcar_du_of_table, rcdu->dev)->data; > > + platform_set_drvdata(pdev, rcdu); > + > + /* I/O resources */ > + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + rcdu->mmio = devm_ioremap_resource(&pdev->dev, mem); > + if (IS_ERR(rcdu->mmio)) > + ret = PTR_ERR(rcdu->mmio); [...] Last line above should be: return PTR_ERR(rcdu->mmio); This is an error introduced in the backport, not the upstream commit. Ben. -- Ben Hutchings Software Developer, Codethink Ltd.