Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752043AbdHGQoL (ORCPT ); Mon, 7 Aug 2017 12:44:11 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:37995 "EHLO mail-it0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834AbdHGQoJ (ORCPT ); Mon, 7 Aug 2017 12:44:09 -0400 Subject: Re: [PATCH] z2ram: Delete four error messages for a failed memory allocation in z2_open() To: Joe Perches , SF Markus Elfring , kernel-janitors@vger.kernel.org Cc: LKML References: <83b6c012-07ca-39df-cfd4-0c4791ecda3d@users.sourceforge.net> <91f7d9cd-3428-b3f0-1833-3a7f63de505a@kernel.dk> <1502124184.2219.26.camel@perches.com> From: Jens Axboe Message-ID: <1a4e615a-1744-66a4-35cb-04f4ff9a52f7@kernel.dk> Date: Mon, 7 Aug 2017 10:44:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502124184.2219.26.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 688 Lines: 20 On 08/07/2017 10:43 AM, Joe Perches wrote: > On Mon, 2017-08-07 at 10:08 -0600, Jens Axboe wrote: >> On 08/07/2017 10:06 AM, SF Markus Elfring wrote: >>> From: Markus Elfring >>> Date: Mon, 7 Aug 2017 17:56:53 +0200 >>> >>> Omit extra messages for a memory allocation failure in this function. >> >> Please stop sending these, thanks. > > It would be pretty funny if Markus actually had a working > Amiga / Zorro II board running the latest kernel and had > actually tested this patch. Doesn't look like he even compiles then. Which means that the investment I have to make in reviewing them is that much greater, it's just not worth it. -- Jens Axboe