Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751857AbdHGRYT (ORCPT ); Mon, 7 Aug 2017 13:24:19 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:27347 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbdHGRYR (ORCPT ); Mon, 7 Aug 2017 13:24:17 -0400 From: Paul Burton To: Ralf Baechle CC: Nathan Sullivan , , , , Subject: Re: [PATCH v6] MIPS: NI 169445 board support Date: Mon, 7 Aug 2017 10:24:05 -0700 Message-ID: <11583742.zienCqJRO5@np-p-burton> Organization: Imagination Technologies In-Reply-To: <20170807152648.GA13214@linux-mips.org> References: <1500402549-12090-1-git-send-email-nathan.sullivan@ni.com> <20170807152648.GA13214@linux-mips.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart10043099.6gJe9OrT0o"; micalg=pgp-sha256; protocol="application/pgp-signature" X-Originating-IP: [10.20.1.88] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2167 Lines: 68 --nextPart10043099.6gJe9OrT0o Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Ralf, On Monday, 7 August 2017 08:26:48 PDT Ralf Baechle wrote: > On Tue, Jul 18, 2017 at 01:29:09PM -0500, Nathan Sullivan wrote: > > diff --git a/arch/mips/generic/vmlinux.its.S > > b/arch/mips/generic/vmlinux.its.S index f67fbf1..de851f7 100644 > > --- a/arch/mips/generic/vmlinux.its.S > > +++ b/arch/mips/generic/vmlinux.its.S > > @@ -29,3 +29,28 @@ > > > > }; > > > > }; > > > > }; > > > > + > > +#ifdef CONFIG_FIT_IMAGE_FDT_NI169445 > > +/ { > > + images { > > [...] > > > + }; > > +}; > > +#endif > > There's been a reject on this file because of a Boston #ifdefed section. > I've fixed that up but we need a cleaner solution. Paul, any suggestions? > > Ralf One possibility would be for us to split the board portions of vmlinux.its.S out into a file per-board, perhaps board-boston.its.S, board-ni169445.its.S etc. The build process would then have to concatenate the right files to generate the full image tree source. Does that sound good to you? Thanks, Paul --nextPart10043099.6gJe9OrT0o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEELIGR03D5+Fg+69wPgiDZ+mk8HGUFAlmIojUACgkQgiDZ+mk8 HGVg3w/9Gucp7naDPxM6pNazBbP7jbzfMYX4UV5M6FiXifgLZxD4+C8jDBAnoMwM zdv+UeaOsYmIfdrJyKIDQuALXXV/T8+BJ4nIXOkQUUVdhKaTzNWKd7XHFRwkn1sO 6RxvayxXtOVGgEv+HrsIFEEybA1DgY+SHp1sqMiA+VI2ms+p3tCaE5qtjPF7rVDL XW7FX1HtQK3RqHg2Pt0jN8BH2bcy6hwvPBt1i7ke1EfoDXLAOZML4oVc8pjyWmV0 O1ppDavAXICy9BIsDAeLZxvyBOom9klXv3s+riHrGbOmiON9uqLFVezUiS4/zpgJ UQjlyY1IEUBxVqlruOl9iJzTw33PWBod2MPlDtfc9CbhKRvzlX+19C2ePHp+GVxl WQYuZ1kf9jhsLedF3XKEGbHYFR3CmEvIUfMo1oEZQtWmFQVUuqM9RdmCZm4r4QUw +7vR7za4B2V1cOdbVxz8idBwFMJWLV+hP4GPvZFtfKzX6n/N8L4wKroomCO4kPw9 quVpYC2XmeKiQFryJCbq2Wgcsdv3XUiKsEUDBtcp6rewub4dLzL1spJZmcqU48lS KlXnFY1ZQrQWDGurayimJ8kcS68FDur7eruw6KiI+d+wMdO7a3WwcCk1LVktjoEB EACE87X74TnlfFqPDVwQZiwkHu5jzMf+yWiw2V0CIrpKn8OAQ68= =gnJ0 -----END PGP SIGNATURE----- --nextPart10043099.6gJe9OrT0o--