Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751829AbdHGS2P (ORCPT ); Mon, 7 Aug 2017 14:28:15 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:47399 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbdHGS2O (ORCPT ); Mon, 7 Aug 2017 14:28:14 -0400 Subject: Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() To: SF Markus Elfring , linuxppc-dev@lists.ozlabs.org Cc: Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , LKML , kernel-janitors@vger.kernel.org References: From: Geoff Levand Message-ID: <8d140d00-935c-da0a-ff2e-167abe642bda@infradead.org> Date: Mon, 7 Aug 2017 11:28:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 726 Lines: 23 On 08/07/2017 09:27 AM, SF Markus Elfring wrote: >>> Omit an extra message for a memory allocation failure in this function. >>> >>> This issue was detected by using the Coccinelle software. >> >> NACK >> >> When a user asks me for help I would certainly like to get >> 'Could not allocate cache tags' as apposed to nothing, > > Do you find the default allocation failure report insufficient? The default is OK. I didn't consider one would be triggered by the kzalloc failure. >> since the return value of ps3vram_cache_init() is not checked. > > Are there any more update candidates to consider for better exception handling? The return of ps3vram_cache_init() should be checked. Feel free to propose others. -Geoff