Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262267AbTFZSZ6 (ORCPT ); Thu, 26 Jun 2003 14:25:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262269AbTFZSZ6 (ORCPT ); Thu, 26 Jun 2003 14:25:58 -0400 Received: from smtpzilla2.xs4all.nl ([194.109.127.138]:8712 "EHLO smtpzilla2.xs4all.nl") by vger.kernel.org with ESMTP id S262267AbTFZSZ5 (ORCPT ); Thu, 26 Jun 2003 14:25:57 -0400 Date: Thu, 26 Jun 2003 20:40:05 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@serv To: Matthew Wilcox cc: David Woodhouse , Subject: Re: [PATCH] BINFMT_ZFLAT can't be a module In-Reply-To: <20030626180909.GP451@parcelfarce.linux.theplanet.co.uk> Message-ID: References: <20030626180909.GP451@parcelfarce.linux.theplanet.co.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1486 Lines: 38 Hi, On Thu, 26 Jun 2003, Matthew Wilcox wrote: > BINFMT_ZFLAT is an attribute of BINFMT_FLAT not a distinct option in > its own right. So the test in lib/Kconfig has to be changed to something > like this: > > Index: lib/Kconfig > =================================================================== > RCS file: /var/cvs/linux-2.5/lib/Kconfig,v > retrieving revision 1.4 > diff -u -p -r1.4 Kconfig > --- lib/Kconfig 8 Apr 2003 15:20:57 -0000 1.4 > +++ lib/Kconfig 26 Jun 2003 18:07:41 -0000 > @@ -17,8 +17,8 @@ config CRC32 > # > config ZLIB_INFLATE > tristate > - default y if CRAMFS=y || PPP_DEFLATE=y || JFFS2_FS=y || ZISOFS_FS=y || BINFMT_ZFLAT=y || CRYPTO_DEFLATE=y > - default m if CRAMFS=m || PPP_DEFLATE=m || JFFS2_FS=m || ZISOFS_FS=m || BINFMT_ZFLAT=m || CRYPTO_DEFLATE=m > + default y if CRAMFS=y || PPP_DEFLATE=y || JFFS2_FS=y || ZISOFS_FS=y || CRYPTO_DEFLATE=y || (BINFMT_FLAT=y && BINFMT_ZFLAT=y) > + default m if CRAMFS=m || PPP_DEFLATE=m || JFFS2_FS=m || ZISOFS_FS=m || CRYPTO_DEFLATE=m || (BINFMT_FLAT=m && BINFMT_ZFLAT=y) This can be simplified now to: config ZLIB_INFLATE def_tristate CRAMFS || PPP_DEFLATE || JFFS2_FS || \ ZISOFS_FS || CRYPTO_DEFLATE || \ (BINFMT_FLAT && BINFMT_ZFLAT) bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/