Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751945AbdHGSta (ORCPT ); Mon, 7 Aug 2017 14:49:30 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:52294 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbdHGSt2 (ORCPT ); Mon, 7 Aug 2017 14:49:28 -0400 Subject: Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() To: SF Markus Elfring , linuxppc-dev@lists.ozlabs.org Cc: Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , LKML , kernel-janitors@vger.kernel.org References: <8d140d00-935c-da0a-ff2e-167abe642bda@infradead.org> <32cdcd8a-1000-223c-71da-4c9119954d4e@users.sourceforge.net> From: Geoff Levand Message-ID: <3a657b44-2bc8-ee05-3a42-db7af354967e@infradead.org> Date: Mon, 7 Aug 2017 11:49:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <32cdcd8a-1000-223c-71da-4c9119954d4e@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 539 Lines: 17 On 08/07/2017 11:34 AM, SF Markus Elfring wrote: >> I didn't consider one would be triggered by the kzalloc failure. > > Do you reconsider any special system settings for further > software evolution then? Sorry, I don't quite understand your question. I think your original patch is OK, and I would appreciate if you added a check for failure of ps3vram_cache_init() in ps3vram_probe(). If you decide not to add that check I'll create a patch for it later. If this doesn't answer your question, could you please rephrase it? -Geoff