Reply-To: shuah@kernel.org
Subject: Re: [PATCH] selftests: futex: convert test to use ksft TAP13
 framework
To: Stafford Horne <shorne@gmail.com>,
        Shuah Khan <shuahkh@osg.samsung.com>
Cc: dvhart@infradead.org, tglx@linutronix.de, mingo@redhat.com,
        peterz@infradead.org, naresh.kamboju@linaro.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        Shuah Khan <shuah@kernel.org>
References: <20170805004650.31046-1-shuahkh@osg.samsung.com>
 <20170805151541.GB3031@lianli.shorne-pla.net>
From: Shuah Khan <shuah@kernel.org>
Message-ID: <ea5870ba-f0c1-e838-967d-29f0622fb3aa@kernel.org>
Date: Mon, 7 Aug 2017 15:10:59 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170805151541.GB3031@lianli.shorne-pla.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1374
Lines: 56

On 08/05/2017 09:15 AM, Stafford Horne wrote:
> On Fri, Aug 04, 2017 at 06:46:50PM -0600, Shuah Khan wrote:
>> Convert test to use ksft TAP13 framework.
> 
> 
>> --- a/tools/testing/selftests/futex/include/logging.h
>> +++ b/tools/testing/selftests/futex/include/logging.h
>> @@ -109,22 +109,20 @@ void log_verbosity(int level)
>>   */
>>  void print_result(const char *test_name, int ret)
>>  {
>> -	const char *result = "Unknown return code";
>> -
>>  	switch (ret) {
>>  	case RET_PASS:
>> -		ksft_inc_pass_cnt();
>> -		result = PASS;
>> -		break;
>> +		ksft_test_result_pass("%s\n", test_name);
>> +		ksft_print_cnts();
>> +		return;
>>  	case RET_ERROR:
>> -		result = ERROR;
>> -		break;
>> +		ksft_test_result_error("%s\n", test_name);
>> +		ksft_print_cnts();
>> +		return;
> 
> This looks ok to me, but this function `ksft_test_result_error` was added
> in another patch you just sent, it was a bit hard to review.

thanks for the review.

> 
> If you need to make and updates, could you please send a series next?

I should have sent it as a series in the first place. Sorry about that.

> 
> -Stafford
> 
>>  	case RET_FAIL:
>> -		ksft_inc_fail_cnt();
>> -		result = FAIL;
>> -		break;
>> +		ksft_test_result_fail("%s\n", test_name);
>> +		ksft_print_cnts();
>> +		return;
>>  	}
>> -	printf("selftests: %s [%s]\n", test_name, result);
> 
> 
> 

thanks,
-- Shuah