Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752066AbdHGVSl (ORCPT ); Mon, 7 Aug 2017 17:18:41 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36314 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751662AbdHGVSj (ORCPT ); Mon, 7 Aug 2017 17:18:39 -0400 Date: Mon, 07 Aug 2017 14:18:38 -0700 (PDT) Message-Id: <20170807.141838.1486515755418560591.davem@davemloft.net> To: privat@egil-hjelmeland.no Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v4 net-next 0/5] Refactor lan9303_xxx_packet_processing From: David Miller In-Reply-To: <20170805110550.26337-1-privat@egil-hjelmeland.no> References: <20170805110550.26337-1-privat@egil-hjelmeland.no> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 07 Aug 2017 14:18:39 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 738 Lines: 19 From: Egil Hjelmeland Date: Sat, 5 Aug 2017 13:05:45 +0200 > This series is purely non functional. > > It changes the lan9303_enable_packet_processing, > lan9303_disable_packet_processing() to pass port number (0,1,2) as > parameter instead of port offset. This aligns them with > other functions in the module, and makes it possible to simplify the code. > > The lan9303_enable_packet_processing, lan9303_disable_packet_processing > functions operate on port. Therefore rename the functions to reflect that > as well. > > Reviewer pointed out lan9303_get_ethtool_stats would be better off with > the use of a lan9303_read_switch_port(). So that was added to the series. ... Series applied, thank you.