Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751961AbdHHCVV (ORCPT ); Mon, 7 Aug 2017 22:21:21 -0400 Received: from ozlabs.org ([103.22.144.67]:46791 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751639AbdHHCVT (ORCPT ); Mon, 7 Aug 2017 22:21:19 -0400 From: Michael Ellerman To: Rob Herring , "devicetree\@vger.kernel.org" , linuxppc-dev Cc: "linux-kernel\@vger.kernel.org" , Frank Rowand , Benjamin Herrenschmidt , Paul Mackerras Subject: Re: [PATCH 0/4] Removing full paths from DT full_name In-Reply-To: References: <20170725214427.25768-1-robh@kernel.org> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 08 Aug 2017 12:21:18 +1000 Message-ID: <87mv7aol41.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1260 Lines: 30 Rob Herring writes: > On Tue, Jul 25, 2017 at 4:44 PM, Rob Herring wrote: >> This series is the last steps to remove storing the full path for every >> DT node. Instead, we can create full path strings dynamically as needed >> with printf %pOF specifiers (commit ce4fecf1fe15). There are a number of >> remaining direct users of full_name after this series. I don't believe >> there should be any functional impact for those users with the change to >> only the node name (+unit-address). The majority are for struct >> resource.name. This should only affect /proc/iomem display. >> >> Patches 1 and 2 can be applied now for 4.14. For patches 3 and 4, my >> target is 4.15 after all the dependencies have been merged. >> >> PPC folks, Please test! The PPC parts are untested. A git branch with >> all the dependencies is here[1]. > > PPC folks, any chance to test this? I got stuck on your %pOF conversion, which broke the vio.c code, because of: - if (!strcmp(parent_node->full_name, "/ibm,platform-facilities")) + if (!strcmp(parent_node->full_name, "ibm,platform-facilities")) But full_name hasn't been changed yet. But patch 1 here should fix that, so I'll pull it all together and try and get it tested. cheers