Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752012AbdHHCtI (ORCPT ); Mon, 7 Aug 2017 22:49:08 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:37861 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758AbdHHCtG (ORCPT ); Mon, 7 Aug 2017 22:49:06 -0400 Date: Mon, 7 Aug 2017 19:49:02 -0700 From: Dmitry Torokhov To: Linus Walleij Cc: Danilo Krummrich , "linux-kernel@vger.kernel.org" , Linux Input , "devicetree@vger.kernel.org" Subject: Re: [PATCH] serio: PS2 gpio bit banging driver for the serio bus Message-ID: <20170808024902.GA12328@dtor-ws> References: <20170731222452.22887-1-danilokrummrich@dk-develop.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 673 Lines: 26 On Mon, Aug 07, 2017 at 11:03:53AM +0200, Linus Walleij wrote: > On Tue, Aug 1, 2017 at 12:24 AM, Danilo Krummrich > wrote: > > > +config SERIO_GPIO_PS2 > > + tristate "GPIO PS/2 bit banging driver" > > + help > > + Say Y here if you want PS/2 bit banging support via GPIO. > > + > > + To compile this driver as a module, choose M here: the > > + module will be called gpio-ps2. > > + > > + If you are unsure, say N. > > As mentioned > > depends on GPIOLIB > depends on OF I do not think this driver has to depend on OF. It should use gpiod and generic device properties. Thanks. -- Dmitry