Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752001AbdHHEL6 (ORCPT ); Tue, 8 Aug 2017 00:11:58 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:58446 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750736AbdHHEL4 (ORCPT ); Tue, 8 Aug 2017 00:11:56 -0400 Subject: Re: [PATCH 3.18 00/50] 3.18.64-stable review To: Greg Kroah-Hartman Cc: Willy Tarreau , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, shuahkh@osg.samsung.com, patches@kernelci.org, ben.hutchings@codethink.co.uk, stable@vger.kernel.org References: <20170804231550.830518786@linuxfoundation.org> <0c5a48b4-72b2-853d-9947-123a57dcc2c6@roeck-us.net> <20170805024657.GA1963@kroah.com> <20170805025107.GB1963@kroah.com> <20170805055511.GA6322@1wt.eu> <20170805060217.GB6322@1wt.eu> <20170805154330.GA2625@kroah.com> <20170807193443.GA5250@kroah.com> From: Guenter Roeck Message-ID: <845b038c-d7ff-cfec-ef6a-8106c970a08d@roeck-us.net> Date: Mon, 7 Aug 2017 21:11:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170807193443.GA5250@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3289 Lines: 86 On 08/07/2017 12:34 PM, Greg Kroah-Hartman wrote: > On Sat, Aug 05, 2017 at 12:11:19PM -0700, Guenter Roeck wrote: >> On 08/05/2017 08:43 AM, Greg Kroah-Hartman wrote: >>> On Sat, Aug 05, 2017 at 08:02:17AM +0200, Willy Tarreau wrote: >>>> On Sat, Aug 05, 2017 at 07:55:11AM +0200, Willy Tarreau wrote: >>>>> On Fri, Aug 04, 2017 at 07:51:07PM -0700, Greg Kroah-Hartman wrote: >>>>>> On Fri, Aug 04, 2017 at 07:46:57PM -0700, Greg Kroah-Hartman wrote: >>>>>>> On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote: >>>>>>>> On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote: >>>>>>>>> This is the start of the stable review cycle for the 3.18.64 release. >>>>>>>>> There are 50 patches in this series, all will be posted as a response >>>>>>>>> to this one. If anyone has any issues with these being applied, please >>>>>>>>> let me know. >>>>>>>>> >>>>>>>>> Responses should be made by Sun Aug 6 23:15:34 UTC 2017. >>>>>>>>> Anything received after that time might be too late. >>>>>>>>> >>>>>>>> >>>>>>>> Preliminary: >>>>>>>> >>>>>>>> Lots of >>>>>>>> >>>>>>>> lib/string.c:31:32: fatal error: asm/word-at-a-time.h >>>>>>>> >>>>>>>> affecting several architectures. >>>>>>>> >>>>>>>> alpha: >>>>>>>> >>>>>>>> lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask' >>>>>>> >>>>>>> Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support >>>>>>> zero_bytemask() on alpha and tile"), right? Any other arches failing? >>>>>> >>>>>> Hm, that doesn't work, do we care about tile? :) >>>>>> >>>>>> Let me see how deep this hole is, I just wanted to get strscpy into 3.18 >>>>>> to fix a bug... >>>>> >>>>> I suspect you'll need this one which came as part of the strscpy() series >>>>> between 4.2 and 4.3 (though I have not tested) : >>>>> >>>>> commit a6e2f029ae34f41adb6ae3812c32c5d326e1abd2 >>>>> Author: Chris Metcalf >>>>> Date: Wed Apr 29 12:48:40 2015 -0400 >>>>> >>>>> Make asm/word-at-a-time.h available on all architectures >>>>> Added the x86 implementation of word-at-a-time to the >>>>> generic version, which previously only supported big-endian. >>>>> (...) >>>> >>>> OK I just applied it on top of 3.18.64-rc1 and it allowed me to build mips >>>> which previously broke. It will not apply as-is, you'll need to drop the >>>> change for arch/nios2/include/asm/Kbuild, and after that it's OK. >>> >>> Thanks for that, I've now queued that patch up. >>> >> >> Better, but there are still some errors. >> >> powerpc: >> lib/string.c: In function 'strscpy': >> lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask' >> >> tile: >> arch/tile/gxio/mpipe.c:46:15: error: conflicting types for 'strscpy' >> include/linux/string.h:29:22: note: previous declaration of 'strscpy' was here >> >> Missing patches: >> >> 7a5692e6e533 ("arch/powerpc: provide zero_bytemask() for big-endian") >> 30059d494a72 ("tile: use global strscpy() rather than private copy") > > Thanks for these, I'll queue them up. And do a -rc2 in a few days as > this was a mess... > Getting there. With v3.18.63-62-gc7d9ae0: Build results: total: 136 pass: 136 fail: 0 Qemu test results: total: 111 pass: 111 fail: 0 Details are available at http://kerneltests.org/builders. Guenter