From: Qiang Zhao <qiang.zhao@nxp.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
        "tglx@linutronix.de" <tglx@linutronix.de>
CC: "oss@buserror.net" <oss@buserror.net>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        Xiaobo Xie <xiaobo.xie@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC
Thread-Topic: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC
Thread-Index: AQHTDyyugWXZTa3Bc0GhquFo9YhZjqJ4d9WAgAGFzsA=
Date: Tue, 8 Aug 2017 06:21:12 +0000
Message-ID: <AM3PR04MB1185747366C53DCC51A8A88F918A0@AM3PR04MB1185.eurprd04.prod.outlook.com>
References: <1502075236-24078-1-git-send-email-qiang.zhao@nxp.com>
 <1502075236-24078-5-git-send-email-qiang.zhao@nxp.com>
 <87h8xjq2rw.fsf@concordia.ellerman.id.au>
In-Reply-To: <87h8xjq2rw.fsf@concordia.ellerman.id.au>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2017 06:21:12.9410
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB514
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v786LNw5004410
Content-Length: 2135
Lines: 53

On Mon 8/7/2017 3:02 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:

> -----Original Message-----
> From: Michael Ellerman [mailto:mpe@ellerman.id.au]
> Sent: Monday, August 07, 2017 3:02 PM
> To: Qiang Zhao <qiang.zhao@nxp.com>; tglx@linutronix.de
> Cc: oss@buserror.net; Qiang Zhao <qiang.zhao@nxp.com>; linuxppc-
> dev@lists.ozlabs.org; Xiaobo Xie <xiaobo.xie@nxp.com>; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC
> 
> Zhao Qiang <qiang.zhao@nxp.com> writes:
> 
> > QEIC was supported on PowerPC, and dependent on PPC, Now it is
> > supported on other platforms, so remove PPCisms.
> >
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> >  arch/powerpc/platforms/83xx/km83xx.c          |   1 -
> >  arch/powerpc/platforms/83xx/misc.c            |   1 -
> >  arch/powerpc/platforms/83xx/mpc832x_mds.c     |   1 -
> >  arch/powerpc/platforms/83xx/mpc832x_rdb.c     |   1 -
> >  arch/powerpc/platforms/83xx/mpc836x_mds.c     |   1 -
> >  arch/powerpc/platforms/83xx/mpc836x_rdk.c     |   1 -
> >  arch/powerpc/platforms/85xx/corenet_generic.c |   1 -
> >  arch/powerpc/platforms/85xx/mpc85xx_mds.c     |   1 -
> >  arch/powerpc/platforms/85xx/mpc85xx_rdb.c     |   1 -
> >  arch/powerpc/platforms/85xx/twr_p102x.c       |   1 -
> >  drivers/irqchip/irq-qeic.c                    | 188 +++++++++++---------------
> >  include/soc/fsl/qe/qe_ic.h                    | 132 ------------------
> >  12 files changed, 80 insertions(+), 250 deletions(-)  delete mode
> > 100644 include/soc/fsl/qe/qe_ic.h
> >
> > diff --git a/arch/powerpc/platforms/83xx/km83xx.c
> > b/arch/powerpc/platforms/83xx/km83xx.c
> > index d8642a4..b1cef0a 100644
> > --- a/arch/powerpc/platforms/83xx/km83xx.c
> > +++ b/arch/powerpc/platforms/83xx/km83xx.c
> > @@ -38,7 +38,6 @@
> >  #include <sysdev/fsl_soc.h>
> >  #include <sysdev/fsl_pci.h>
> >  #include <soc/fsl/qe/qe.h>
> > -#include <soc/fsl/qe/qe_ic.h>
> 
> You deleted that file in patch 2. So didn't you just break the build for the last two
> commits?

Sorry, I am not sure what you said. Could you explain?
Thank you!

BR
Qiang Zhao