Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752068AbdHHHCN (ORCPT ); Tue, 8 Aug 2017 03:02:13 -0400 Received: from mail-ua0-f193.google.com ([209.85.217.193]:35608 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751880AbdHHHCM (ORCPT ); Tue, 8 Aug 2017 03:02:12 -0400 Date: Tue, 8 Aug 2017 16:02:26 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ross Zwisler , "karam . lee" , seungho1.park@lge.com, Matthew Wilcox , Christoph Hellwig , Dan Williams , Dave Chinner , jack@suse.cz, Jens Axboe , Vishal Verma , linux-nvdimm@lists.01.org, kernel-team , Sergey Senozhatsky Subject: Re: [PATCH v1 5/6] zram: remove zram_rw_page Message-ID: <20170808070226.GC7765@jagdpanzerIV.localdomain> References: <1502175024-28338-1-git-send-email-minchan@kernel.org> <1502175024-28338-6-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502175024-28338-6-git-send-email-minchan@kernel.org> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 636 Lines: 18 On (08/08/17 15:50), Minchan Kim wrote: > With on-stack-bio, rw_page interface doesn't provide a clear performance > benefit for zram and surely has a maintenance burden, so remove the > last user to remove rw_page completely. OK, never really liked it, I think we had that conversation before. as far as I remember, zram_rw_page() was the reason we had to do some tricks with init_lock to make lockdep happy. may be now we can "simplify" the things back. > Cc: Sergey Senozhatsky > Signed-off-by: Minchan Kim Reviewed-by: Sergey Senozhatsky -ss