Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752170AbdHHHlt (ORCPT ); Tue, 8 Aug 2017 03:41:49 -0400 Received: from mail-yw0-f171.google.com ([209.85.161.171]:33748 "EHLO mail-yw0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751698AbdHHHls (ORCPT ); Tue, 8 Aug 2017 03:41:48 -0400 MIME-Version: 1.0 In-Reply-To: <20170808073931.GB26652@cbox> References: <1502165135-4784-1-git-send-email-longpeng2@huawei.com> <1502165135-4784-5-git-send-email-longpeng2@huawei.com> <20170808073931.GB26652@cbox> From: Christoffer Dall Date: Tue, 8 Aug 2017 09:41:46 +0200 Message-ID: Subject: Re: [PATCH v2 4/4] KVM: arm: implements the kvm_arch_vcpu_in_kernel() To: "Longpeng(Mike)" Cc: Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Alexander Graf , Christian Borntraeger , cohuck@redhat.com, Christoffer Dall , "marc.zyngier@arm.com" , James Hogan , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , weidong.huang@huawei.com, arei.gonglei@huawei.com, wangxinxin.wang@huawei.com, longpeng.mike@gmail.com, David Hildenbrand Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1131 Lines: 38 On Tue, Aug 8, 2017 at 9:39 AM, Christoffer Dall wrote: > On Tue, Aug 08, 2017 at 12:05:35PM +0800, Longpeng(Mike) wrote: >> This implements the kvm_arch_vcpu_in_kernel() for ARM. >> >> Signed-off-by: Longpeng(Mike) >> --- >> virt/kvm/arm/arm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c >> index 862f820..b9f68e4 100644 >> --- a/virt/kvm/arm/arm.c >> +++ b/virt/kvm/arm/arm.c >> @@ -418,7 +418,7 @@ int kvm_arch_vcpu_runnable(struct kvm_vcpu *v) >> >> bool kvm_arch_vcpu_in_kernel(struct kvm_vcpu *vcpu) >> { >> - return false; >> + return vcpu_mode_priv(vcpu); >> } >> >> /* Just ensure a guest exit from a particular CPU */ >> -- >> 1.8.3.1 >> >> > I'm not taking any position on whether this series makes sense overall > or not (it's a bit concerning to do this without having measured a > benefit), but for the arm/arm64 change: oh, sorry, strike that, I didn't notice you had added performance results in the cover letter. Thanks, -Christoffer > > Acked-by: Christoffer Dall