DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CF5FE5AFE8
Date: Tue, 8 Aug 2017 09:41:53 +0200
From: Cornelia Huck <cohuck@redhat.com>
To: "Longpeng(Mike)" <longpeng2@huawei.com>
Cc: <pbonzini@redhat.com>, <rkrcmar@redhat.com>, <agraf@suse.com>,
        <borntraeger@de.ibm.com>, <christoffer.dall@linaro.org>,
        <marc.zyngier@arm.com>, <james.hogan@imgtec.com>,
        <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <weidong.huang@huawei.com>, <arei.gonglei@huawei.com>,
        <wangxinxin.wang@huawei.com>, <longpeng.mike@gmail.com>,
        <david@redhat.com>
Subject: Re: [PATCH v2 0/4] KVM: optimize the kvm_vcpu_on_spin
Message-ID: <20170808094153.1b5bf8f4@gondolin>
In-Reply-To: <1502165135-4784-1-git-send-email-longpeng2@huawei.com>
References: <1502165135-4784-1-git-send-email-longpeng2@huawei.com>
Organization: Red Hat GmbH
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 600
Lines: 18

On Tue, 8 Aug 2017 12:05:31 +0800
"Longpeng(Mike)" <longpeng2@huawei.com> wrote:

> This is a simple optimization for kvm_vcpu_on_spin, the
> main idea is described in patch-1's commit msg.

I think this generally looks good now.

> 
> I did some tests base on the RFC version, the result shows
> that it can improves the performance slightly.

Did you re-run tests on this version?

I would also like to see some s390 numbers; unfortunately I only have a
z/VM environment and any performance numbers would be nearly useless
there. Maybe somebody within IBM with a better setup can run a quick
test?