Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752334AbdHHIPE (ORCPT <rfc822;w@1wt.eu>);
        Tue, 8 Aug 2017 04:15:04 -0400
Received: from szxga05-in.huawei.com ([45.249.212.191]:2581 "EHLO
        szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752075AbdHHIPC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 8 Aug 2017 04:15:02 -0400
Message-ID: <598972E3.1030807@huawei.com>
Date: Tue, 8 Aug 2017 16:14:27 +0800
From: "Longpeng (Mike)" <longpeng2@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1
MIME-Version: 1.0
To: Cornelia Huck <cohuck@redhat.com>
CC: <pbonzini@redhat.com>, <rkrcmar@redhat.com>, <agraf@suse.com>,
        <borntraeger@de.ibm.com>, <christoffer.dall@linaro.org>,
        <marc.zyngier@arm.com>, <james.hogan@imgtec.com>,
        <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <weidong.huang@huawei.com>, <arei.gonglei@huawei.com>,
        <wangxinxin.wang@huawei.com>, <longpeng.mike@gmail.com>,
        <david@redhat.com>
Subject: Re: [PATCH v2 0/4] KVM: optimize the kvm_vcpu_on_spin
References: <1502165135-4784-1-git-send-email-longpeng2@huawei.com> <20170808094153.1b5bf8f4@gondolin>
In-Reply-To: <20170808094153.1b5bf8f4@gondolin>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.246.209]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
        refid=str=0001.0A090203.59897303.0099,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
        ip=0.0.0.0,
        so=2014-11-16 11:51:01,
        dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 199fda3346ce46a8dede5e4b895471ec
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1031
Lines: 41



On 2017/8/8 15:41, Cornelia Huck wrote:

> On Tue, 8 Aug 2017 12:05:31 +0800
> "Longpeng(Mike)" <longpeng2@huawei.com> wrote:
> 
>> This is a simple optimization for kvm_vcpu_on_spin, the
>> main idea is described in patch-1's commit msg.
> 
> I think this generally looks good now.
> 
>>
>> I did some tests base on the RFC version, the result shows
>> that it can improves the performance slightly.
> 
> Did you re-run tests on this version?


Hi Cornelia,

I didn't re-run tests on V2. But the major difference between RFC and V2
is that V2 only cache result for X86 (s390/arm needn't) and V2 saves a
expensive operation ( 440-1400 cycles on my test machine ) for X86/VMX.

So I think V2's performance is at least the same as RFC or even slightly
better. :)

> 
> I would also like to see some s390 numbers; unfortunately I only have a
> z/VM environment and any performance numbers would be nearly useless
> there. Maybe somebody within IBM with a better setup can run a quick
> test?
> 
> .
> 


-- 
Regards,
Longpeng(Mike)