Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752080AbdHHI3u (ORCPT <rfc822;w@1wt.eu>);
        Tue, 8 Aug 2017 04:29:50 -0400
Received: from mout.web.de ([212.227.17.11]:56080 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750818AbdHHI3s (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 8 Aug 2017 04:29:48 -0400
Subject: Re: block/ps3vram: Delete an error message for a failed memory
 allocation in ps3vram_cache_init()
To: Geoff Levand <geoff@infradead.org>, linuxppc-dev@lists.ozlabs.org
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Jens Axboe <axboe@kernel.dk>, Jim Paris <jim@jtan.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Paul Mackerras <paulus@samba.org>
References: <e22ee16a-5f34-46bd-577f-9b7ca75e9035@users.sourceforge.net>
 <b6b5f2f0-bbfe-8471-d8fc-e236ea0b1ea4@infradead.org>
 <dd16f28c-1613-cfb2-5349-07aaac2f2f5a@users.sourceforge.net>
 <8d140d00-935c-da0a-ff2e-167abe642bda@infradead.org>
 <32cdcd8a-1000-223c-71da-4c9119954d4e@users.sourceforge.net>
 <3a657b44-2bc8-ee05-3a42-db7af354967e@infradead.org>
 <57b472a0-0245-f821-cea8-171c34cc9df7@users.sourceforge.net>
 <db00e381-a79e-4db2-2263-458b80e4844c@infradead.org>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <a4b69182-80d3-c5e6-ab7a-6da2b99e5ddc@users.sourceforge.net>
Date: Tue, 8 Aug 2017 10:23:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <db00e381-a79e-4db2-2263-458b80e4844c@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:2gKPuCr13s1h6V9NKZhxLsO4GbdBC2HqkQ5Cd/Q/waxJqyryD/V
 y4j9O4pvQMrP0rWLoJuKfpEfhyBMDJXqufdBoBz9Kr11G7uJgDqrrpw3jcZnNdCIC7bBn4J
 A5cSDIJ1rxw5qJINWGuyy0H6nIBANKEIhTer09GjSmlP2aCo/n5Il7g9MFoxfaq89eFsqs/
 XTJbi4Y3zq4jJ2MGlw2Yw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:YJRKlgrxsfM=:iKmreYLYlkXJSZltNmUa7b
 ObLu9lewv3OdOADd1Xz8/T8ziSmvL4v1BM5BWBYf8mOaj22gjMxB3EzgZXUhBMjLiA5zbxFma
 qbdbCUmZd4xgybJSrl9SyliMWIfBPlIy8iClMKGxHv1rna865KnZGenH8dpimJ/+NDavWkKDL
 t1G+PSGccB6i2b5+JOiYa39xfN83VbkQ3A8SZHCHfzJ4uacDP4zWhp9uHbe13xIddwgMu17uP
 Hoy/hR8KlpSlC+vRG2rYAVsDYHGeG1/tKMwmH3ESXYx2DtCvNktN8t0yEBgnTApWDMI2Brlum
 ga/zeJnyMeov3VUDWQyLS7NX8Izj009egbnTeKwZDJMxH5RYkhJQPsMG9aLcFsFvSUjR4ZHl0
 QoQEFfGenXy9lKn9A6sU16mNGkLifbgABrrp6oQYbrb4x8uHla1RrdGHgsSJ1tG5mbz5WgSE0
 AHSWLZ/UCZHZ07LFI0ezy6QRhfVoVtKCipUSWrOuTp2L+mlSYJKPLdniNImAgGgpAvkCfZGjv
 1CpFb2JOjWNwvZ87k5xQ3F9vE4nb2UfUOXw0fxxAvT6uM4uos7tL4gQV7fshSj+dSPduTlBMq
 o6dIwUpJdX2EJAJW/LB102YkY0z32FqydF+FELZ+KzawsXQ76Cq66nfMI3rHTB6Uo8ba1a+wU
 ZGutoNfT65uQ6GtQTkCpKiSK8O5dp8lHTJbBSlmZjU44t9EmIwr9iZMDNfWhXZmmSZX+4InGp
 DR29L7P5W8sDxMMQfMGJ8VH/6uMbu3moosSXFYjbxaG8K4N8/B3K0dcfDjBKqKyMhUYoz6nRh
 kGvRp0L8OlLiCDZYkYhv30RtXZ2+8zAqwkr4Cr41zysCmqxnF4=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 810
Lines: 30

>> https://patchwork.ozlabs.org/patch/798575/
> 
> I submitted your patch

Thanks for your constructive feedback.
https://patchwork.ozlabs.org/patch/798850/


> and a fix to ps3vram_probe() with the other patches in my queue.

I find it nice that you picked this change opportunity up after
a bit of discussion (before an other developer would eventually
have tackled it also).

“Check return of ps3vram_cache_init”
https://patchwork.ozlabs.org/patch/798853/

1. Unfortunately, I find that this specific update suggestion does not fit
   to the Linux coding style convention.

   “…
   Do not unnecessarily use braces where a single statement will do.
   …”

2. How do you think about to use the check “if (error)” instead?

3. Will an additional commit description be useful?

Regards,
Markus