Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752123AbdHHIbE (ORCPT ); Tue, 8 Aug 2017 04:31:04 -0400 Received: from merlin.infradead.org ([205.233.59.134]:58690 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751983AbdHHIbC (ORCPT ); Tue, 8 Aug 2017 04:31:02 -0400 Date: Tue, 8 Aug 2017 10:30:53 +0200 From: Peter Zijlstra To: Yafang Shao Cc: gregkh@linuxfoundation.org, jslaby@suse.com, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] scheduler: enhancement to show_state_filter Message-ID: <20170808083053.37aaregzlws4aquz@hirez.programming.kicks-ass.net> References: <1502196790-12585-1-git-send-email-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502196790-12585-1-git-send-email-laoar.shao@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 730 Lines: 14 On Tue, Aug 08, 2017 at 08:53:10PM +0800, Yafang Shao wrote: > Sometimes we want to get tasks in TASK_RUNNING sepcifically, > instead of dump all tasks. > For example, when the loadavg are high, we want to dump > tasks in TASK_RUNNING and TASK_UNINTERRUPTIBLE, which contribute > to system load. But mostly there're lots of tasks in Sleep state, > which occupies almost all of the kernel log buffer, even overflows > it, that causes the useful messages get lost. Although we can > enlarge the kernel log buffer, but that's not a good idea. > > So I made this change to make the show_state_filter more flexible, > and then we can dump the tasks in TASK_RUNNING specifically. It reads like magic and I really don't see the point.