Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752064AbdHHIfY (ORCPT ); Tue, 8 Aug 2017 04:35:24 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:29681 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750818AbdHHIfW (ORCPT ); Tue, 8 Aug 2017 04:35:22 -0400 Message-ID: <1502181319.24341.38.camel@mtksdaap41> Subject: Re: [PATCH] memory: mtk-smi: Handle return value of clk_prepare_enable From: Honghui Zhang To: Arvind Yadav CC: , , , Date: Tue, 8 Aug 2017 16:35:19 +0800 In-Reply-To: <2c1de1862ce9fdefe7653706915c146038b12c4c.1502167256.git.arvind.yadav.cs@gmail.com> References: <472bce58da459a7c64d0ad1cd39b74fa0fcf77f1.1502167256.git.arvind.yadav.cs@gmail.com> <2c1de1862ce9fdefe7653706915c146038b12c4c.1502167256.git.arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 43 On Tue, 2017-08-08 at 11:06 +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- Hi, Arvind, please rebase this to my latest patchset[1], it's been applied by Joerg. And please send this one to Joerg and iommu mail list. otherwise: Acked-by: Honghui Zhang [1]https://lkml.org/lkml/2017/8/3/968 Thanks. > drivers/memory/mtk-smi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index 4afbc41..edf36f0 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -321,6 +321,7 @@ static int mtk_smi_common_probe(struct platform_device *pdev) > struct resource *res; > const struct of_device_id *of_id; > enum mtk_smi_gen smi_gen; > + int ret; > > if (!dev->pm_domain) > return -EPROBE_DEFER; > @@ -359,7 +360,9 @@ static int mtk_smi_common_probe(struct platform_device *pdev) > if (IS_ERR(common->clk_async)) > return PTR_ERR(common->clk_async); > > - clk_prepare_enable(common->clk_async); > + ret = clk_prepare_enable(common->clk_async); > + if (ret) > + return ret; > } > pm_runtime_enable(dev); > platform_set_drvdata(pdev, common);