Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753148AbdHHIz0 (ORCPT ); Tue, 8 Aug 2017 04:55:26 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:46261 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752580AbdHHIzY (ORCPT ); Tue, 8 Aug 2017 04:55:24 -0400 Date: Tue, 8 Aug 2017 05:55:14 -0300 From: Mauro Carvalho Chehab To: Jonathan Corbet Cc: Linux Doc Mailing List , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org Subject: Re: [PATCH] scripts/sphinx-pre-install: add minimum support for RHEL Message-ID: <20170808055514.28fc2057@vento.lan> In-Reply-To: <20170807142733.6642b226@lwn.net> References: <20170807142733.6642b226@lwn.net> Organization: Samsung X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1816 Lines: 45 Em Mon, 7 Aug 2017 14:27:33 -0600 Jonathan Corbet escreveu: > On Mon, 24 Jul 2017 09:09:24 -0300 > Mauro Carvalho Chehab wrote: > > > RHEL 7.x and clone distros are shipped with Sphinx 1.1.x, > > with is incompatible with Kernel ReST markups. > > > > So, on those systems, the only alternative is to install > > it via a Python virtual environment. > > > > While seeking for "pip" on CentOS 7.3, I noticed that it > > is not really needed, as python-virtualenv has its version > > packaged there already. So, remove this from the list of > > requirements for all distributions. > > > > With regards to PDF, twe need at least texlive-tabulary > > extension, but that is not shipped there (at least on > > CentOS). So, disable PDF packages as a hole. > > > > Please notice, however, that texlive + amsmath is needed for > > ReST to properly handle ReST ".. math::" tags. Yet, Sphinx > > fall back to display the LaTeX math expressions as-is, if > > such extension is not available. > > > > So, let's just disable all texlive packages as a hole. > > I've applied this, finally. Couldn't resist the temptation to fix "as a > whole" while I was at it :) Thanks for applying - and for fixing the "whole" typo ;) Yeah, RHEL/CentOS was likely the big missing gap at the script. With time, people may end adding other distros there too. As most distros either use .deb or .rpm packaging[1], I suspect it shouldn't be hard to add support for them when needed, as they'll end by either use the existing logic, or require a close enough logic. [1] Well, last time I checked, Slackware still use tarballs. Slackware was the first distro I used, back on Kernel 1.0 days. If I ever become nostalgic enough, I might eventually write a patch for it some day. Thanks, Mauro