Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbdHHJAo (ORCPT ); Tue, 8 Aug 2017 05:00:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34398 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbdHHJAi (ORCPT ); Tue, 8 Aug 2017 05:00:38 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 85941800AF Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Re: [PATCH 13/18] power: supply: bq24190_charger: Export 5V boost converter as regulator To: Liam Breck Cc: Darren Hart , Andy Shevchenko , Wolfram Sang , Sebastian Reichel , Greg Kroah-Hartman , Guenter Roeck , Heikki Krogerus , platform-driver-x86@vger.kernel.org, linux-kernel , linux-i2c@vger.kernel.org, Tony Lindgren , linux-pm@vger.kernel.org, devel@driverdev.osuosl.org References: <20170806123555.5124-1-hdegoede@redhat.com> <20170806123555.5124-14-hdegoede@redhat.com> From: Hans de Goede Message-ID: Date: Tue, 8 Aug 2017 11:00:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 08 Aug 2017 09:00:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 879 Lines: 27 Hi, On 08-08-17 10:39, Liam Breck wrote: > Hi Hans, > > On Sun, Aug 6, 2017 at 5:35 AM, Hans de Goede wrote: >> Register the 5V boost converter as a regulator named >> "regulator-bq24190-usb-vbus". Note the name includes "bq24190" because >> the bq24190 family is also used on ACPI devices where there are no >> device-tree phandles, so regulator_get will fallback to the name and thus >> it must be unique on the system. > > What we're enabling here is 5V boost for otg host mode, not vbus > generally, so maybe the name should indicate that... > > regulator-bq24190-usb-5volt > regulator-bq24190-usb-host > regulator-bq24190-usb-otg-5v I picked vbus because that gets used a lot already in similar cases, but I agree that we should probably come up with a better name. I like "regulator-bq24190-usb-otg-5v", shall I use that for v2? Regards, Hans