Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752092AbdHHKYo (ORCPT ); Tue, 8 Aug 2017 06:24:44 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:56209 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbdHHKYn (ORCPT ); Tue, 8 Aug 2017 06:24:43 -0400 Date: Tue, 8 Aug 2017 12:24:38 +0200 From: Peter Zijlstra To: Yafang Shao Cc: gregkh@linuxfoundation.org, jslaby@suse.com, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] scheduler: enhancement to show_state_filter Message-ID: <20170808102438.teglqelqih52tnst@hirez.programming.kicks-ass.net> References: <1502196790-12585-1-git-send-email-laoar.shao@gmail.com> <20170808083053.37aaregzlws4aquz@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 386 Lines: 11 On Tue, Aug 08, 2017 at 04:50:23PM +0800, Yafang Shao wrote: > Hi Peter, > > The point is we call use it as bellow, > show_state_filter(TASK_RUNNING); > because TASK_RUNNING is 0, that will dump all tasks. > > Under some circumstance, we need this to dump only tasks in TASK_RUNNING state. But the patch doesn't introduce any of that. It just makes the existing code unreadable.