Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752211AbdHHKkh (ORCPT ); Tue, 8 Aug 2017 06:40:37 -0400 Received: from ozlabs.org ([103.22.144.67]:46905 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751925AbdHHKkg (ORCPT ); Tue, 8 Aug 2017 06:40:36 -0400 From: Michael Ellerman To: Sukadev Bhattiprolu Cc: Benjamin Herrenschmidt , tglx@linutronix.de, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc: xive: ensure active irqd when setting affinity In-Reply-To: <20170803013822.GD28905@us.ibm.com> References: <20170803013822.GD28905@us.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 08 Aug 2017 20:40:33 +1000 Message-ID: <87zibamjfi.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 945 Lines: 24 Sukadev Bhattiprolu writes: > From fd0abf5c61b6041fdb75296e8580b86dc91d08d6 Mon Sep 17 00:00:00 2001 > From: Benjamin Herrenschmidt > Date: Tue, 1 Aug 2017 20:54:41 -0500 > Subject: [PATCH] powerpc: xive: ensure active irqd when setting affinity > > Ensure irqd is active before attempting to set affinity. This should > make the set affinity code more robust. For instance, this prevents > these messages seen on a 4.12 based kernel when taking cpus offline: > > [ 123.053037264,3] XIVE[ IC 00 ] ISN 2 lead to invalid IVE ! > [ 77.885859] xive: Error -6 reconfiguring irq 17 > [ 77.885862] IRQ17: set affinity failed(-6). > > The underlying problem with taking cpus offline was fixed in 4.13-rc1 by: > > commit 91f26cb4cd3c ("genirq/cpuhotplug: Do not migrated shutdown irqs") So do we still need this? Or is the above only a partial fix? I'm a bit confused. cheers