Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752213AbdHHLlQ (ORCPT ); Tue, 8 Aug 2017 07:41:16 -0400 Received: from mail-qk0-f178.google.com ([209.85.220.178]:38300 "EHLO mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133AbdHHLlO (ORCPT ); Tue, 8 Aug 2017 07:41:14 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Ulf Hansson Date: Tue, 8 Aug 2017 13:41:12 +0200 Message-ID: Subject: Re: [PATCH v3 0/4] add support of SCPSYS power domain for MediaTek MT7622 To: sean.wang@mediatek.com Cc: Rob Herring , Matthias Brugger , "Rafael J. Wysocki" , Kevin Hilman , "devicetree@vger.kernel.org" , linux-mediatek@lists.infradead.org, "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1519 Lines: 43 On 7 August 2017 at 09:24, wrote: > From: Sean Wang > > Changes since v2: > - reduce code duplication of scpsys_probe across all SoCs > > Changes since v1: > - rebase to Linux v4.13-rc1 > > There are four power domains on MediaTek MT7622 SoC which are respectively > ETHSYS for Ethernet including extra embedded switch, HIF0SYS for PCI-E and > SATA, HIF1SYS for USB and WBSYS for WIFI and Bluetooth. > > Those functions could be selectively powered gated when the corresponding > function is no longer to use in order to reach more minimal power > dissipation through the patch series introduced here. > > Chen Zhong (1): > soc: mediatek: add header files required for MT7622 SCPSYS dt-binding > > Sean Wang (3): > dt-bindings: soc: update the binding document for SCPSYS on MediaTek > MT7622 SoC > soc: mediatek: reduce code duplication of scpsys_probe across all SoCs > soc: mediatek: add SCPSYS power domain driver for MediaTek MT7622 SoC > > .../devicetree/bindings/soc/mediatek/scpsys.txt | 3 + > drivers/soc/mediatek/mtk-scpsys.c | 247 ++++++++++++--------- > include/dt-bindings/power/mt7622-power.h | 22 ++ > include/linux/soc/mediatek/infracfg.h | 7 + > 4 files changed, 179 insertions(+), 100 deletions(-) > create mode 100644 include/dt-bindings/power/mt7622-power.h > > -- > 2.7.4 > Looks good to me! Feel free to add: Reviewed-by: Ulf Hansson Kind regards Uffe