Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752076AbdHHMfs (ORCPT ); Tue, 8 Aug 2017 08:35:48 -0400 Received: from server.coly.li ([162.144.45.48]:56654 "EHLO server.coly.li" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751880AbdHHMfq (ORCPT ); Tue, 8 Aug 2017 08:35:46 -0400 Subject: Re: [PATCH v3 33/49] bcache: convert to bio_for_each_segment_all_sp() To: Ming Lei , Jens Axboe , Christoph Hellwig , Huang Ying , Andrew Morton , Alexander Viro Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-bcache@vger.kernel.org References: <20170808084548.18963-1-ming.lei@redhat.com> <20170808084548.18963-34-ming.lei@redhat.com> From: Coly Li Message-ID: Date: Tue, 8 Aug 2017 20:35:14 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170808084548.18963-34-ming.lei@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.coly.li X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - coly.li X-Get-Message-Sender-Via: server.coly.li: authenticated_id: i@coly.li X-Authenticated-Sender: server.coly.li: i@coly.li X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 32 On 2017/8/8 下午4:45, Ming Lei wrote: > Cc: linux-bcache@vger.kernel.org > Signed-off-by: Ming Lei The patch is good to me. Thanks. Acked-by: Coly Li > --- > drivers/md/bcache/btree.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c > index 3da595ae565b..74cbb7387dc5 100644 > --- a/drivers/md/bcache/btree.c > +++ b/drivers/md/bcache/btree.c > @@ -422,8 +422,9 @@ static void do_btree_node_write(struct btree *b) > int j; > struct bio_vec *bv; > void *base = (void *) ((unsigned long) i & ~(PAGE_SIZE - 1)); > + struct bvec_iter_all bia; > > - bio_for_each_segment_all(bv, b->bio, j) > + bio_for_each_segment_all_sp(bv, b->bio, j, bia) > memcpy(page_address(bv->bv_page), > base + j * PAGE_SIZE, PAGE_SIZE); > > -- Coly Li