Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752110AbdHHMqV (ORCPT ); Tue, 8 Aug 2017 08:46:21 -0400 Received: from mail.ispras.ru ([83.149.199.45]:53180 "EHLO mail.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993AbdHHMqU (ORCPT ); Tue, 8 Aug 2017 08:46:20 -0400 From: Anton Volkov Subject: Question about bh1770glc.ko To: arnd@arndb.de, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org, Alexey Khoroshilov , samu.p.onkalo@nokia.com Message-ID: <82306a0e-9c44-47da-277a-78e1d4bd6f33@ispras.ru> Date: Tue, 8 Aug 2017 15:46:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 528 Lines: 15 Hello. In drivers/misc/bh1770glc.c several functions have comments stating that they must be called under lock protection, e.g. bh1770_prox_mode_control, bh1770_lux_interrupt_control, bh1770_lux_rate, bh1770_chip_on. However there are places where they are called without lock being held, e.g. during the bh1770_resume. Do you know anything about whether this is intended or this is a bug? Thank you for your time. -- Anton Volkov Linux Verification Center, ISPRAS web: http://linuxtesting.org e-mail: avolkov@ispras.ru