Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752548AbdHHNeW (ORCPT ); Tue, 8 Aug 2017 09:34:22 -0400 Received: from mail-lf0-f46.google.com ([209.85.215.46]:37617 "EHLO mail-lf0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752279AbdHHNeR (ORCPT ); Tue, 8 Aug 2017 09:34:17 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: <20170807065827.GC32434@dhcp22.suse.cz> References: <20170802105018.GA2529@dhcp22.suse.cz> <20170803081152.GC12521@dhcp22.suse.cz> <5aca0179-3b04-aa1a-58cd-668a04f63ae7@I-love.SAKURA.ne.jp> <20170803103337.GH12521@dhcp22.suse.cz> <201708031944.JCB39029.SJOOOLHFQFMVFt@I-love.SAKURA.ne.jp> <20170803110548.GK12521@dhcp22.suse.cz> <20170804075636.GD26029@dhcp22.suse.cz> <20170807065827.GC32434@dhcp22.suse.cz> From: Paul Moore Date: Tue, 8 Aug 2017 09:34:15 -0400 Message-ID: Subject: Re: suspicious __GFP_NOMEMALLOC in selinux To: Michal Hocko , mgorman@suse.de Cc: Tetsuo Handa , linux-kernel@vger.kernel.org, linux-mm@kvack.org, selinux@tycho.nsa.gov Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1622 Lines: 41 On Mon, Aug 7, 2017 at 2:58 AM, Michal Hocko wrote: > On Fri 04-08-17 13:12:04, Paul Moore wrote: >> On Fri, Aug 4, 2017 at 3:56 AM, Michal Hocko wrote: > [...] >> > Btw. Should I resend the patch or somebody will take it from this email >> > thread? >> >> No, unless your mailer mangled the patch I should be able to pull it >> from this thread. However, I'm probably going to let this sit until >> early next week on the odd chance that anyone else wants to comment on >> the flag choice. I'll send another reply once I merge the patch. > > OK, there is certainly no hurry for merging this. Thanks! > -- > Michal Hocko > SUSE Labs Merged into selinux/next with this patch description, and your sign-off (I had to munge the description a bit based on the thread). Are you okay with this, especially your sign-off? commit 476accbe2f6ef69caeebe99f52a286e12ac35aee Author: Michal Hocko Date: Thu Aug 3 10:11:52 2017 +0200 selinux: use GFP_NOWAIT in the AVC kmem_caches There is a strange __GFP_NOMEMALLOC usage pattern in SELinux, specifically GFP_ATOMIC | __GFP_NOMEMALLOC which doesn't make much sense. GFP_ATOMIC on its own allows to access memory reserves while __GFP_NOMEMALLOC dictates we cannot use memory reserves. Replace this with the much more sane GFP_NOWAIT in the AVC code as we can tolerate memory allocation failures in that code. Signed-off-by: Michal Hocko Acked-by: Mel Gorman Signed-off-by: Paul Moore -- paul moore www.paul-moore.com