Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752458AbdHHNvX (ORCPT ); Tue, 8 Aug 2017 09:51:23 -0400 Received: from foss.arm.com ([217.140.101.70]:36244 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752391AbdHHNvV (ORCPT ); Tue, 8 Aug 2017 09:51:21 -0400 Date: Tue, 8 Aug 2017 14:51:17 +0100 From: Catalin Marinas To: Yury Norov Cc: Pratyush Anand , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] arm64: introduce separated bits for mm_context_t flags Message-ID: <20170808135117.xxcpwonnrnqiqtq6@armageddon.cambridge.arm.com> References: <20170805144022.17260-1-ynorov@caviumnetworks.com> <20170805144022.17260-2-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170805144022.17260-2-ynorov@caviumnetworks.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 573 Lines: 17 On Sat, Aug 05, 2017 at 05:40:21PM +0300, Yury Norov wrote: > diff --git a/arch/arm64/include/asm/mmu.h b/arch/arm64/include/asm/mmu.h > index 5468c834b072..2c57b06b2883 100644 > --- a/arch/arm64/include/asm/mmu.h > +++ b/arch/arm64/include/asm/mmu.h > @@ -16,6 +16,8 @@ > #ifndef __ASM_MMU_H > #define __ASM_MMU_H > > +#define MMCF_AARCH32 0x0 /* MM hosts AArch32 executables */ Nitpick: drop 0x since it's a bit number not a flag value. We could, however, make it a value and just stop using (set|clear)_bit functions. There is no atomicity issue here. -- Catalin