Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752259AbdHHN4B (ORCPT ); Tue, 8 Aug 2017 09:56:01 -0400 Received: from m12-17.163.com ([220.181.12.17]:57222 "EHLO m12-17.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752092AbdHHNz7 (ORCPT ); Tue, 8 Aug 2017 09:55:59 -0400 From: Pan Bian To: qla2xxx-upstream@qlogic.com, "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Pan Bian Subject: scsi: qla2xxx: use dma_mapping_error to check map errors Date: Tue, 8 Aug 2017 21:55:30 +0800 Message-Id: <1502200531-15219-1-git-send-email-bianpan2016@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: EcCowADXc8HewolZdmp5DQ--.45488S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Gry8Wr47XrW8CFy3Gr1UAwb_yoWfWFc_ur WUZrW7XFsakr17Xwn2qF93J3yS9rW8Xr4F9F109a43C34ruw13ZryvvFykZan7W3yUuFWD Ca1UZrWrZr18WjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnP73DUUUUU== X-Originating-IP: [106.120.213.62] X-CM-SenderInfo: held01tdqsiiqw6rljoofrz/xtbBZwEucletmx5MIAAAsp Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 25 The return value of dma_map_single() should be checked by dma_mapping_error(). However, in function qla26xx_dport_diagnostics(), its return value is checked against NULL, which could result in failures. Signed-off-by: Pan Bian --- drivers/scsi/qla2xxx/qla_mbx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 7c6d1a4..eafb709 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -5817,7 +5817,7 @@ struct cs84xx_mgmt_cmd { dd_dma = dma_map_single(&vha->hw->pdev->dev, dd_buf, size, DMA_FROM_DEVICE); - if (!dd_dma) { + if (dma_mapping_error(&vha->hw->pdev->dev, dd_dma)) { ql_log(ql_log_warn, vha, 0x1194, "Failed to map dma buffer.\n"); return QLA_MEMORY_ALLOC_FAILED; } -- 1.9.1