Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752249AbdHHOCA (ORCPT ); Tue, 8 Aug 2017 10:02:00 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:37811 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbdHHOB7 (ORCPT ); Tue, 8 Aug 2017 10:01:59 -0400 Subject: Re: [PATCH v2 0/3] fix xen hvm guest with kaslr enabled To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org References: <20170728102314.29100-1-jgross@suse.com> <8a07a112-ffc2-885a-95d3-bb4ba7658a83@suse.com> Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com From: Boris Ostrovsky Message-ID: <7c78d567-fd19-0c9b-9af0-8465e70993fa@oracle.com> Date: Tue, 8 Aug 2017 10:00:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <8a07a112-ffc2-885a-95d3-bb4ba7658a83@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1161 Lines: 36 On 08/08/2017 02:46 AM, Juergen Gross wrote: > On 28/07/17 12:23, Juergen Gross wrote: >> This patch series fixes a regression introduced in 4.13-rc1: A Xen >> HVM guest with KASLR enabled wouldn't boot any longer due to the usage >> of __va() before kernel_randomize_memory() was called. >> >> Changes in V2: >> - patch 1: test for x86_hyper being not NULL >> >> Juergen Gross (3): >> x86: provide an init_mem_mapping hypervisor hook >> xen: split up xen_hvm_init_shared_info() >> xen: fix hvm guest with kaslr enabled >> >> arch/x86/include/asm/hypervisor.h | 10 +++++++ >> arch/x86/mm/init.c | 3 ++ >> arch/x86/xen/enlighten_hvm.c | 59 ++++++++++++++++++++++++--------------- >> 3 files changed, 50 insertions(+), 22 deletions(-) >> > Could I have some feedback, please? > > I'd like to get this regression fixed in 4.13. > > In case nobody objects this week I'll just add the patches to the Xen > tree for rc5. As I said before I think .init_mem_mapping() could live in x86_platform_ops() but this works too, so Reviewed-by: Boris Ostrovsky But this still wants x86 maintainers' ACK. -boris