Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752203AbdHHO57 (ORCPT ); Tue, 8 Aug 2017 10:57:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53748 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752010AbdHHO57 (ORCPT ); Tue, 8 Aug 2017 10:57:59 -0400 Date: Tue, 8 Aug 2017 07:57:57 -0700 From: Greg KH To: Anton Volkov Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org, Alexey Khoroshilov , samu.p.onkalo@nokia.com Subject: Re: Question about bh1770glc.ko Message-ID: <20170808145757.GA18035@kroah.com> References: <82306a0e-9c44-47da-277a-78e1d4bd6f33@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82306a0e-9c44-47da-277a-78e1d4bd6f33@ispras.ru> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 523 Lines: 13 On Tue, Aug 08, 2017 at 03:46:18PM +0300, Anton Volkov wrote: > Hello. > > In drivers/misc/bh1770glc.c several functions have comments stating that > they must be called under lock protection, e.g. bh1770_prox_mode_control, > bh1770_lux_interrupt_control, bh1770_lux_rate, bh1770_chip_on. However there > are places where they are called without lock being held, e.g. during the > bh1770_resume. Do you know anything about whether this is intended or this > is a bug? > > Thank you for your time. I have no idea, sorry.