Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752195AbdHHPJP (ORCPT ); Tue, 8 Aug 2017 11:09:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:51174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbdHHPJO (ORCPT ); Tue, 8 Aug 2017 11:09:14 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9938122C9E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org MIME-Version: 1.0 In-Reply-To: <87mv7aol41.fsf@concordia.ellerman.id.au> References: <20170725214427.25768-1-robh@kernel.org> <87mv7aol41.fsf@concordia.ellerman.id.au> From: Rob Herring Date: Tue, 8 Aug 2017 10:08:52 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/4] Removing full paths from DT full_name To: Michael Ellerman Cc: "devicetree@vger.kernel.org" , linuxppc-dev , "linux-kernel@vger.kernel.org" , Frank Rowand , Benjamin Herrenschmidt , Paul Mackerras Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1848 Lines: 45 On Mon, Aug 7, 2017 at 9:21 PM, Michael Ellerman wrote: > Rob Herring writes: > >> On Tue, Jul 25, 2017 at 4:44 PM, Rob Herring wrote: >>> This series is the last steps to remove storing the full path for every >>> DT node. Instead, we can create full path strings dynamically as needed >>> with printf %pOF specifiers (commit ce4fecf1fe15). There are a number of >>> remaining direct users of full_name after this series. I don't believe >>> there should be any functional impact for those users with the change to >>> only the node name (+unit-address). The majority are for struct >>> resource.name. This should only affect /proc/iomem display. >>> >>> Patches 1 and 2 can be applied now for 4.14. For patches 3 and 4, my >>> target is 4.15 after all the dependencies have been merged. >>> >>> PPC folks, Please test! The PPC parts are untested. A git branch with >>> all the dependencies is here[1]. >> >> PPC folks, any chance to test this? > > I got stuck on your %pOF conversion, which broke the vio.c code, because of: > > - if (!strcmp(parent_node->full_name, "/ibm,platform-facilities")) > + if (!strcmp(parent_node->full_name, "ibm,platform-facilities")) > > But full_name hasn't been changed yet. Ah, those lines need to be dropped from the %pOF conversion. I'll send a new version. What I was originally considering here was just: strcmp(kbasename(parent_node->full_name), "ibm,platform-facilities") That would work for "/foo/ibm,platform-facilities" too, but IMO validation of the DT is not the kernel's job (if it is, we're doing a horrible job). But in the end here, I decided to keep the existing full path matching as patch 1 does. > But patch 1 here should fix that, so I'll pull it all together and try > and get it tested. Thanks. Rob