Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752195AbdHHPYX (ORCPT ); Tue, 8 Aug 2017 11:24:23 -0400 Received: from mail-cys01nam02on0077.outbound.protection.outlook.com ([104.47.37.77]:60373 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752017AbdHHPYV (ORCPT ); Tue, 8 Aug 2017 11:24:21 -0400 From: "Madhani, Himanshu" To: Pan Bian CC: Dept-Eng QLA2xxx Upstream , "James E.J. Bottomley" , "Martin K. Petersen" , Linux SCSI Mailinglist , "linux-kernel@vger.kernel.org" Subject: Re: scsi: qla2xxx: use dma_mapping_error to check map errors Thread-Topic: scsi: qla2xxx: use dma_mapping_error to check map errors Thread-Index: AQHTEE4PnD/GpNrEEEiEoy49WDzX8aJ6lDEA Date: Tue, 8 Aug 2017 15:24:19 +0000 Message-ID: <543DFC27-27D2-4868-87C1-C941D752E966@cavium.com> References: <1502200531-15219-1-git-send-email-bianpan2016@163.com> In-Reply-To: <1502200531-15219-1-git-send-email-bianpan2016@163.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Himanshu.Madhani@cavium.com; x-originating-ip: [67.161.21.64] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR07MB3453;7:9NU6BD1LLYROHO+jkxtuzfwx2i7UTWJJZFbBmYh8mgn37mLZV28aV6p8AkEo/d+TdibKubZW71X+smeIVYZ6879MKKIdZwzb2rUGpu0Daw7JAHvkTnodw7PWZzJRQRnAZg+ahrez6nWR//MvftxWp9vF5pWPYOBGbTRKioDGyGahhw1wKSunEGCcjPSDiIJjBxqZPbeCctSBxy/VZ70q1VSeztjRINChJM/bPHDmbe7wBpd7mT5MSwsv+WnGjmXWur9NCPvSIONbLsct3W1SQpvIq8nB6z/Vkj/lQFwjHkzE1n/sT8inT9gOzcCWi6ho1nP3NZu0MKeyx+XfnZQVyC6k7ml1eEyGxDCsiZCcpdHY2+9Gev5RwGRVoWaHDjPImqk5prAeqOxR7io8p7pZEbawsF1gTW+CX9rMAXTT2wk3Uz+9OFRZSX9p+vvRPExCFh23fuT7rKwKDEH2w+a4JfQZ1XDawv63SxW03E4UhkbLx+VQ3Ob9sBzV9cN5CQfKB39NABFUuHNswltRRE4yzrXqGpCEwgeQSAQnjt3hKtSh6dKZhcEpYiECQm+HFWzvty/IEgQrOrgvXH2Tgq8mDJk4SKQph5ImXZZ/RABKQB9/Uin1o8SqWMRePeQGHVWh4vSs8U8kjJu+gDj4v82jPgnQF83RjhS27RAhtsaHLx56XPvSkSxkMpA0WvhjYyuKBuxxAP8481BRLaINGY6r2JVUFgxCnuBNQa9oQR7kz8fhTbfd6WwAoltyTjiwlZM06IrD/FMVelXxl2CQwZUTbrWjD3a/LPCDNurT9BHe59w= x-ms-office365-filtering-correlation-id: a525975b-439b-4897-c006-08d4de7189eb x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:MWHPR07MB3453; x-ms-traffictypediagnostic: MWHPR07MB3453: x-exchange-antispam-report-test: UriScan:(130843839470238); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123560025)(20161123558100)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR07MB3453;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR07MB3453; x-forefront-prvs: 03932714EB x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39400400002)(39410400002)(39840400002)(39450400003)(39850400002)(199003)(189002)(51914003)(24454002)(377454003)(50986999)(102836003)(54356999)(105586002)(6506006)(3280700002)(76176999)(3846002)(101416001)(25786009)(33656002)(6116002)(2906002)(97736004)(7736002)(478600001)(8936002)(106356001)(66066001)(5660300001)(305945005)(6436002)(4326008)(14454004)(110136004)(36756003)(53936002)(38730400002)(54906002)(53546010)(81166006)(99286003)(6246003)(6512007)(8676002)(68736007)(189998001)(77096006)(81156014)(229853002)(82746002)(83716003)(86362001)(72206003)(2900100001)(3660700001)(6486002)(2950100002)(6916009);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB3453;H:MWHPR07MB3455.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <04E49890295AE349B224E1DC166C4C1A@namprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2017 15:24:19.0806 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3453 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v78FOQuP006465 Content-Length: 1078 Lines: 37 > On Aug 8, 2017, at 6:55 AM, Pan Bian wrote: > > The return value of dma_map_single() should be checked by > dma_mapping_error(). However, in function qla26xx_dport_diagnostics(), its > return value is checked against NULL, which could result in failures. > > Signed-off-by: Pan Bian > --- > drivers/scsi/qla2xxx/qla_mbx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c > index 7c6d1a4..eafb709 100644 > --- a/drivers/scsi/qla2xxx/qla_mbx.c > +++ b/drivers/scsi/qla2xxx/qla_mbx.c > @@ -5817,7 +5817,7 @@ struct cs84xx_mgmt_cmd { > > dd_dma = dma_map_single(&vha->hw->pdev->dev, > dd_buf, size, DMA_FROM_DEVICE); > - if (!dd_dma) { > + if (dma_mapping_error(&vha->hw->pdev->dev, dd_dma)) { > ql_log(ql_log_warn, vha, 0x1194, "Failed to map dma buffer.\n"); > return QLA_MEMORY_ALLOC_FAILED; > } > -- > 1.9.1 > > Looks Good. Thanks for the patch Acked-by: Himanshu Madhani Thanks, - Himanshu