Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752937AbdHHQDp (ORCPT ); Tue, 8 Aug 2017 12:03:45 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:47991 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752918AbdHHQDn (ORCPT ); Tue, 8 Aug 2017 12:03:43 -0400 From: Laurent Pinchart To: Bhumika Goyal Cc: julia.lawall@lip6.fr, architt@codeaurora.org, a.hajda@samsung.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/bridge: make drm_bridge_funcs const Date: Tue, 08 Aug 2017 19:03:57 +0300 Message-ID: <2177679.cxpq8VCtMS@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.34-gentoo; KDE/4.14.32; x86_64; ; ) In-Reply-To: <1502207650-20029-1-git-send-email-bhumirks@gmail.com> References: <1502207650-20029-1-git-send-email-bhumirks@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1858 Lines: 51 Hi Bhumika, Thank you for the patch. On Tuesday 08 Aug 2017 21:24:10 Bhumika Goyal wrote: > Make these structures const as they are only stored in the funcs field > of drm_bridge structure, which is of type const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ee16635..58b4fb2 > 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -857,7 +857,7 @@ static int adv7511_bridge_attach(struct drm_bridge > *bridge) return ret; > } > > -static struct drm_bridge_funcs adv7511_bridge_funcs = { > +static const struct drm_bridge_funcs adv7511_bridge_funcs = { > .enable = adv7511_bridge_enable, > .disable = adv7511_bridge_disable, > .mode_set = adv7511_bridge_mode_set, > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 36f5ccb..63c7a01 > 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > @@ -811,7 +811,7 @@ static int dw_mipi_dsi_bridge_attach(struct drm_bridge > *bridge) return drm_bridge_attach(bridge->encoder, dsi->panel_bridge, > bridge); } > > -static struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { > +static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { > .mode_set = dw_mipi_dsi_bridge_mode_set, > .enable = dw_mipi_dsi_bridge_enable, > .post_disable = dw_mipi_dsi_bridge_post_disable, -- Regards, Laurent Pinchart