Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752222AbdHHQcT (ORCPT ); Tue, 8 Aug 2017 12:32:19 -0400 Received: from foss.arm.com ([217.140.101.70]:38154 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752100AbdHHQcS (ORCPT ); Tue, 8 Aug 2017 12:32:18 -0400 Date: Tue, 8 Aug 2017 17:32:20 +0100 From: Will Deacon To: Tyler Baicar Cc: rjw@rjwysocki.net, lenb@kernel.org, james.morse@arm.com, bp@suse.de, shiju.jose@huawei.com, geliangtang@gmail.com, andriy.shevchenko@linux.intel.com, tony.luck@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, austinwc@codeaurora.org Subject: Re: [PATCH] acpi: apei: fix GHES estatus iteration Message-ID: <20170808163219.GB2163@arm.com> References: <1501795945-5331-1-git-send-email-tbaicar@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501795945-5331-1-git-send-email-tbaicar@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 25 On Thu, Aug 03, 2017 at 03:32:25PM -0600, Tyler Baicar wrote: > Currently iterating through the GHES estatus blocks does not > take into account the new generic data v3 structure size. This > can result in garbage non-standard trace events to be triggered > since the loop will not properly iterate through the estatus > blocks and not properly terminate. > > Update the GHES estatus iteration to properly increment through > the estatus blocks similar to how the CPER estatus printing > iterates through them. > > Fixes: bbcc2e7b642e ("ras: acpi/apei: cper: add support for generic data v3 structure") > Signed-off-by: Tyler Baicar > Tested-by: Austin Christ > --- > drivers/acpi/apei/apei-internal.h | 5 ----- > drivers/acpi/apei/ghes.c | 8 +++++++- > 2 files changed, 7 insertions(+), 6 deletions(-) Whilst much of the initial code here went through the arm64 tree in the previous merge window, I'm assuming that Boris will take this fix via his tree (likewise for "[PATCH V2] acpi: apei: clear error status before acknowledging the error"). Will