Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752430AbdHHQde (ORCPT ); Tue, 8 Aug 2017 12:33:34 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:34373 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752370AbdHHQdb (ORCPT ); Tue, 8 Aug 2017 12:33:31 -0400 Subject: Re: blk-mq breaks suspend even with runtime PM patch To: Greg KH , Oleksandr Natalenko Cc: Mike Galbraith , Christoph Hellwig , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <5912148.iRCpNe8Dyb@natalenko.name> <1501391551.17388.31.camel@gmx.de> <1662218.y9oETEnj5A@natalenko.name> <20170808162252.GC23338@kroah.com> From: Jens Axboe Message-ID: <843d7ee7-63b9-d34c-6d91-dea0b940d330@kernel.dk> Date: Tue, 8 Aug 2017 10:33:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170808162252.GC23338@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 31 On 08/08/2017 10:22 AM, Greg KH wrote: > On Sun, Jul 30, 2017 at 03:50:15PM +0200, Oleksandr Natalenko wrote: >> Hello Mike et al. >> >> On neděle 30. července 2017 7:12:31 CEST Mike Galbraith wrote: >>> FWIW, first thing I'd do is update that 4.12.0 to 4.12.4, and see if >>> stable fixed it. >> >> My build already includes v4.12.4. >> >>> If not, I'd find these two commits irresistible. >>> >>> 5f042e7cbd9eb blk-mq: Include all present CPUs in the default queue mapping >>> 4b855ad37194f blk-mq: Create hctx for each present CPU >> >> I've applied these 2 commits, and cannot reproduce the issue anymore. Looks >> like a perfect hit, thanks! >> >>> 'course applying random upstream bits does come with some risk, trying >>> a kernel already containing them has less "entertainment" potential. >> >> Should you consider applying them to v4.12.x stable series? CC'ing Greg just >> in case. > > I can queue these up if I get an ack from the developers/maintainers > that it is ok to do so... You can add those two commits to stable. -- Jens Axboe