Date: Tue, 8 Aug 2017 11:08:02 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: John Stultz <john.stultz@linaro.org>
Cc: Martijn Coenen <maco@android.com>, Todd Kjos <tkjos@google.com>,
        Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Amit Pundir <amit.pundir@linaro.org>,
        lkml <linux-kernel@vger.kernel.org>, devel@driverdev.osuosl.org,
        Martijn Coenen <maco@google.com>
Subject: Re: [PATCH 3/3] ANDROID: binder: fix proc->tsk check.
Message-ID: <20170808180802.GB22755@kroah.com>
References: <20170728115608.61306-1-maco@android.com>
 <20170728115608.61306-4-maco@android.com>
 <CALAqxLXaigM2YyoHXYakJOtyq=nvUbRGeN6skV6y2-D6idKz7w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALAqxLXaigM2YyoHXYakJOtyq=nvUbRGeN6skV6y2-D6idKz7w@mail.gmail.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1558
Lines: 40

On Tue, Aug 08, 2017 at 10:34:47AM -0700, John Stultz wrote:
> On Fri, Jul 28, 2017 at 4:56 AM, Martijn Coenen <maco@android.com> wrote:
> > Commit c4ea41ba195d ("binder: use group leader instead of open thread")'
> > was incomplete and didn't update a check in binder_mmap(), causing all
> > mmap() calls into the binder driver to fail.
> >
> > Signed-off-by: Martijn Coenen <maco@android.com>
> > ---
> >  drivers/android/binder.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> > index f7665c31feca..831cdd7d197d 100644
> > --- a/drivers/android/binder.c
> > +++ b/drivers/android/binder.c
> > @@ -3362,7 +3362,7 @@ static int binder_mmap(struct file *filp, struct vm_area_struct *vma)
> >         const char *failure_string;
> >         struct binder_buffer *buffer;
> >
> > -       if (proc->tsk != current)
> > +       if (proc->tsk != current->group_leader)
> >                 return -EINVAL;
> >
> >         if ((vma->vm_end - vma->vm_start) > SZ_4M)
> 
> Tested-by: John Stultz <john.stultz@linaro.org>
> 
> As Amit already confirmed, this resolves the wifi and bluetooth
> regression I was seeing with Android using 4.13-rc2.
> 
> Though I've not seen it show up in Linus' tree yet, so I wanted to
> pester folks so it gets into 4.13-rc (its given me some slight grief
> trying to bisect down a separate issue).

I will queue this up in the next few days, I need to resolve the patches
that have been sent to me for this, sorry for the delay.

thanks,

greg k-h