Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752433AbdHHSYY (ORCPT ); Tue, 8 Aug 2017 14:24:24 -0400 Received: from mail-qk0-f169.google.com ([209.85.220.169]:35525 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752408AbdHHSYX (ORCPT ); Tue, 8 Aug 2017 14:24:23 -0400 MIME-Version: 1.0 In-Reply-To: <20170808180802.GB22755@kroah.com> References: <20170728115608.61306-1-maco@android.com> <20170728115608.61306-4-maco@android.com> <20170808180802.GB22755@kroah.com> From: John Stultz Date: Tue, 8 Aug 2017 11:24:21 -0700 Message-ID: Subject: Re: [PATCH 3/3] ANDROID: binder: fix proc->tsk check. To: Greg KH Cc: Martijn Coenen , Todd Kjos , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Amit Pundir , lkml , devel@driverdev.osuosl.org, Martijn Coenen Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1727 Lines: 42 On Tue, Aug 8, 2017 at 11:08 AM, Greg KH wrote: > On Tue, Aug 08, 2017 at 10:34:47AM -0700, John Stultz wrote: >> On Fri, Jul 28, 2017 at 4:56 AM, Martijn Coenen wrote: >> > Commit c4ea41ba195d ("binder: use group leader instead of open thread")' >> > was incomplete and didn't update a check in binder_mmap(), causing all >> > mmap() calls into the binder driver to fail. >> > >> > Signed-off-by: Martijn Coenen >> > --- >> > drivers/android/binder.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/android/binder.c b/drivers/android/binder.c >> > index f7665c31feca..831cdd7d197d 100644 >> > --- a/drivers/android/binder.c >> > +++ b/drivers/android/binder.c >> > @@ -3362,7 +3362,7 @@ static int binder_mmap(struct file *filp, struct vm_area_struct *vma) >> > const char *failure_string; >> > struct binder_buffer *buffer; >> > >> > - if (proc->tsk != current) >> > + if (proc->tsk != current->group_leader) >> > return -EINVAL; >> > >> > if ((vma->vm_end - vma->vm_start) > SZ_4M) >> >> Tested-by: John Stultz >> >> As Amit already confirmed, this resolves the wifi and bluetooth >> regression I was seeing with Android using 4.13-rc2. >> >> Though I've not seen it show up in Linus' tree yet, so I wanted to >> pester folks so it gets into 4.13-rc (its given me some slight grief >> trying to bisect down a separate issue). > > I will queue this up in the next few days, I need to resolve the patches > that have been sent to me for this, sorry for the delay. No worries. Just wanted to make sure it hadn't gotten lost. thanks -john