Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752400AbdHHWtN (ORCPT ); Tue, 8 Aug 2017 18:49:13 -0400 Received: from mail-pg0-f52.google.com ([74.125.83.52]:35187 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751970AbdHHWtM (ORCPT ); Tue, 8 Aug 2017 18:49:12 -0400 From: Todd Kjos X-Google-Original-From: Todd Kjos To: gregkh@linuxfoundation.org, arve@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, maco@google.com, dan.carpenter@oracle.com, tkjos@google.com Subject: [PATCH] binder: fix incorrect cmd to binder_stat_br Date: Tue, 8 Aug 2017 15:48:36 -0700 Message-Id: <20170808224836.38951-1-tkjos@google.com> X-Mailer: git-send-email 2.14.0.434.g98096fd7a8-goog Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 924 Lines: 27 commit 26549d177410 ("binder: guarantee txn complete / errors delivered in-order") passed the locally declared and undefined cmd to binder_stat_br() which results in a bogus cmd field in a trace event and BR stats are incremented incorrectly. Change to use e->cmd which has been initialized. Signed-off-by: Todd Kjos --- drivers/android/binder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index 9f95d7093f32..f34fcb513c64 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -3619,7 +3619,7 @@ static int binder_thread_read(struct binder_proc *proc, e->cmd = BR_OK; ptr += sizeof(uint32_t); - binder_stat_br(proc, thread, cmd); + binder_stat_br(proc, thread, e->cmd); } break; case BINDER_WORK_TRANSACTION_COMPLETE: { binder_inner_proc_unlock(proc); -- 2.14.0.434.g98096fd7a8-goog