Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752588AbdHHXNT (ORCPT ); Tue, 8 Aug 2017 19:13:19 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:46848 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752173AbdHHXNR (ORCPT ); Tue, 8 Aug 2017 19:13:17 -0400 Date: Tue, 8 Aug 2017 17:13:06 -0600 From: Jason Gunthorpe To: Mikko Rapeli Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, Moni Shoua , Doug Ledford Subject: Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h Message-ID: <20170808231306.GH29372@obsidianresearch.com> References: <20170806164428.2273-1-mikko.rapeli@iki.fi> <20170806164428.2273-31-mikko.rapeli@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170806164428.2273-31-mikko.rapeli@iki.fi> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 19 On Sun, Aug 06, 2017 at 06:44:21PM +0200, Mikko Rapeli wrote: > Fixes these userspace compilation errors when rdma_user_rxe.h is compiled > alone: > > rdma/rdma_user_rxe.h:59:20: error: field ???_sockaddr??? has incomplete type > struct sockaddr _sockaddr; > ^~~~~~~~~ > rdma/rdma_user_rxe.h:60:22: error: field ???_sockaddr_in??? has incomplete type > struct sockaddr_in _sockaddr_in; > ^~~~~~~~~~~~ > rdma/rdma_user_rxe.h:61:23: error: field ???_sockaddr_in6??? has incomplete type > struct sockaddr_in6 _sockaddr_in6; > ^~~~~~~~~~~~~ I'm not sure this is a good idea, linux/in.h should not be included in userspace users of this file, 'sockaddr_in' needs to come from glibc's 'netinet/in.h' instead.. Jason