From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Will Deacon <will.deacon@arm.com>
Cc: Tyler Baicar <tbaicar@codeaurora.org>, lenb@kernel.org,
        james.morse@arm.com, bp@suse.de, shiju.jose@huawei.com,
        geliangtang@gmail.com, andriy.shevchenko@linux.intel.com,
        tony.luck@intel.com, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, austinwc@codeaurora.org
Subject: Re: [PATCH] acpi: apei: fix GHES estatus iteration
Date: Wed, 09 Aug 2017 02:52:06 +0200
Message-ID: <1971058.u9kdacGNiq@aspire.rjw.lan>
In-Reply-To: <20170808163219.GB2163@arm.com>
References: <1501795945-5331-1-git-send-email-tbaicar@codeaurora.org> <20170808163219.GB2163@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1273
Lines: 29

On Tuesday, August 8, 2017 6:32:20 PM CEST Will Deacon wrote:
> On Thu, Aug 03, 2017 at 03:32:25PM -0600, Tyler Baicar wrote:
> > Currently iterating through the GHES estatus blocks does not
> > take into account the new generic data v3 structure size. This
> > can result in garbage non-standard trace events to be triggered
> > since the loop will not properly iterate through the estatus
> > blocks and not properly terminate.
> > 
> > Update the GHES estatus iteration to properly increment through
> > the estatus blocks similar to how the CPER estatus printing
> > iterates through them.
> > 
> > Fixes: bbcc2e7b642e ("ras: acpi/apei: cper: add support for generic data v3 structure")
> > Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
> > Tested-by: Austin Christ <austinwc@codeaurora.org>
> > ---
> >  drivers/acpi/apei/apei-internal.h | 5 -----
> >  drivers/acpi/apei/ghes.c          | 8 +++++++-
> >  2 files changed, 7 insertions(+), 6 deletions(-)
> 
> Whilst much of the initial code here went through the arm64 tree in the
> previous merge window, I'm assuming that Boris will take this fix via his
> tree (likewise for "[PATCH V2] acpi: apei: clear error status before
> acknowledging the error").

Actually I will if Boris ACKs these.

Thanks,
Rafael