Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752576AbdHIEE0 convert rfc822-to-8bit (ORCPT ); Wed, 9 Aug 2017 00:04:26 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60260 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752187AbdHIEEZ (ORCPT ); Wed, 9 Aug 2017 00:04:25 -0400 Date: Tue, 08 Aug 2017 21:04:24 -0700 (PDT) Message-Id: <20170808.210424.1601241755004039630.davem@davemloft.net> To: Haakon.Bugge@oracle.com Cc: santosh.shilimkar@oracle.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, knut.omang@oracle.com, wei.lin-guay@oracle.com Subject: Re: [PATCH net] rds: Reintroduce statistics counting From: David Miller In-Reply-To: <20170808091332.5413-1-Haakon.Bugge@oracle.com> References: <20170808091332.5413-1-Haakon.Bugge@oracle.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 08 Aug 2017 21:04:24 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 21 From: H?kon Bugge Date: Tue, 8 Aug 2017 11:13:32 +0200 > In commit 7e3f2952eeb1 ("rds: don't let RDS shutdown a connection > while senders are present"), refilling the receive queue was removed > from rds_ib_recv(), along with the increment of > s_ib_rx_refill_from_thread. > > Commit 73ce4317bf98 ("RDS: make sure we post recv buffers") > re-introduces filling the receive queue from rds_ib_recv(), but does > not add the statistics counter. rds_ib_recv() was later renamed to > rds_ib_recv_path(). > > This commit reintroduces the statistics counting of > s_ib_rx_refill_from_thread and s_ib_rx_refill_from_cq. > > Signed-off-by: H?kon Bugge > Reviewed-by: Knut Omang > Reviewed-by: Wei Lin Guay Applied.