Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752137AbdHIE5H (ORCPT ); Wed, 9 Aug 2017 00:57:07 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:35816 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbdHIE5F (ORCPT ); Wed, 9 Aug 2017 00:57:05 -0400 Date: Wed, 9 Aug 2017 12:56:45 +0800 From: Herbert Xu To: Horia =?utf-8?Q?Geant=C4=83?= Cc: Harald Freudenberger , Oleksij Rempel , "linux-kernel@vger.kernel.org" , Oleksij Rempel , Dan Douglass , "linux-crypto@vger.kernel.org" , "kernel@pengutronix.de" , Martin Schwidefsky , "David S. Miller" Subject: Re: [PATCH v1] crypto: caam - set hwrng quality level Message-ID: <20170809045645.GA30804@gondor.apana.org.au> References: <20170719074458.9247-1-o.rempel@pengutronix.de> <20170719163248.sn7mvnq2s3fm2hvh@pengutronix.de> <20170719181303.rj4fyjj7qplatrzk@pengutronix.de> <4e42d639-9f83-dcbb-9a2a-91686656c7dd@linux.vnet.ibm.com> <20170803031652.GA10515@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 626 Lines: 16 On Thu, Aug 03, 2017 at 07:48:51AM +0000, Horia Geantă wrote: > > Right now it's configured as a DRBG. > If I read correctly, it doesn't matter it's using the internal TRNG for > (automated) seeding, it still shouldn't use hwrng. > This means it's broken since the very beginning: > e24f7c9e87d4 crypto: caam - hwrng support Right. If it can be switched over to a TRNG then we should do that. Otherwise it should be converted over to use the crypto rng API. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt