Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752758AbdHIIhx (ORCPT ); Wed, 9 Aug 2017 04:37:53 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:51961 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752324AbdHIIhw (ORCPT ); Wed, 9 Aug 2017 04:37:52 -0400 From: Laurent Pinchart To: Arvind Yadav Cc: architt@codeaurora.org, a.hajda@samsung.com, airlied@linux.ie, elfring@users.sourceforge.net, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures Date: Wed, 09 Aug 2017 11:38:07 +0300 Message-ID: <2774445.RGyCgtBS77@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.34-gentoo; KDE/4.14.32; x86_64; ; ) In-Reply-To: <44c0ccab8b5658d17a3ed553e721136b53d95521.1502264156.git.arvind.yadav.cs@gmail.com> References: <44c0ccab8b5658d17a3ed553e721136b53d95521.1502264156.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1190 Lines: 37 Hi Arvind, Thank you for the patch. On Wednesday 09 Aug 2017 13:08:37 Arvind Yadav wrote: > snd_pcm_ops are not supposed to change at runtime. All functions > working with snd_pcm_ops provided by work with > const snd_pcm_ops. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c index > 8f2d137..cf3f0ca 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c > @@ -517,7 +517,7 @@ static snd_pcm_uframes_t dw_hdmi_pointer(struct > snd_pcm_substream *substream) return bytes_to_frames(runtime, > dw->buf_offset); > } > > -static struct snd_pcm_ops snd_dw_hdmi_ops = { > +static const struct snd_pcm_ops snd_dw_hdmi_ops = { > .open = dw_hdmi_open, > .close = dw_hdmi_close, > .ioctl = snd_pcm_lib_ioctl, -- Regards, Laurent Pinchart