Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbdHIJnh convert rfc822-to-8bit (ORCPT ); Wed, 9 Aug 2017 05:43:37 -0400 Received: from esa2.microchip.iphmx.com ([68.232.149.84]:11321 "EHLO esa2.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940AbdHIJng (ORCPT ); Wed, 9 Aug 2017 05:43:36 -0400 X-IronPort-AV: E=Sophos;i="5.41,346,1498546800"; d="scan'208";a="6027793" Date: Wed, 9 Aug 2017 11:42:39 +0200 From: Christian Gromm To: Arvind Yadav CC: , , , , Subject: Re: [PATCH 1/3] staging: most: usb: constify usb_device_id Message-ID: <20170809114239.2ac9a210@xps13> In-Reply-To: <1502212995-17482-2-git-send-email-arvind.yadav.cs@gmail.com> References: <1502212995-17482-1-git-send-email-arvind.yadav.cs@gmail.com> <1502212995-17482-2-git-send-email-arvind.yadav.cs@gmail.com> Organization: Microchip Technology Germany - AIS Engineering X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2010 Lines: 57 On Tue, 8 Aug 2017 22:53:13 +0530 Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Acked-by: Christian Gromm > --- > drivers/staging/most/hdm-usb/hdm_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c > b/drivers/staging/most/hdm-usb/hdm_usb.c index d0f68cb..a9c3785 100644 > --- a/drivers/staging/most/hdm-usb/hdm_usb.c > +++ b/drivers/staging/most/hdm-usb/hdm_usb.c > @@ -832,7 +832,7 @@ static const struct file_operations hdm_usb_fops > = { /** > * usb_device_id - ID table for HCD device probing > */ > -static struct usb_device_id usbid[] = { > +static const struct usb_device_id usbid[] = { > { USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_BRDG), }, > { USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81118), }, > { USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81119), }, -- thanks, Chris Christian Gromm Principal Software Engineer Microchip Technology Germany II GmbH & Co. KG Emmy-Noether-Straße 14 76131 Karlsruhe | Germany Tel: +49 721 62537 466 | Fax: +49 721 62537 119 christian.gromm@microchip.com | www.microchip.com Firmensitz: Ismaning Registergericht: Amtsgericht München, HRA 98692 Persönlich haftende Gesellschafterin: Microchip Technology Germany GmbH mit Sitz in Ismaning Registergericht: München, HRB 197 653 Geschäftsführer: Mohammed Nawaz Sharif, James Eric Bjornholt, Norbert Siedhoff Diese E-Mail kann vertrauliche Informationen enthalten. Sie darf nicht durch andere als die ursprünglich genannten Adressaten genutzt, kopiert oder weitergeleitet werden. This e-mail may contain confidential information and should not be used, copied or disclosed by anyone who is not the original intended recipient.