Date: Wed, 9 Aug 2017 11:51:07 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: mingo@kernel.org, tglx@linutronix.de, walken@google.com,
        boqun.feng@gmail.com, kirill@shutemov.name,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, willy@infradead.org, npiggin@gmail.com,
        kernel-team@lge.com
Subject: Re: [PATCH v8 09/14] lockdep: Apply crossrelease to completions
Message-ID: <20170809095107.2nzb4m4wq2p77ppb@hirez.programming.kicks-ass.net>
References: <1502089981-21272-1-git-send-email-byungchul.park@lge.com>
 <1502089981-21272-10-git-send-email-byungchul.park@lge.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1502089981-21272-10-git-send-email-byungchul.park@lge.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 870
Lines: 34

On Mon, Aug 07, 2017 at 04:12:56PM +0900, Byungchul Park wrote:
> +static inline void wait_for_completion(struct completion *x)
> +{
> +	complete_acquire(x);
> +	__wait_for_completion(x);
> +	complete_release(x);
> +}
> +
> +static inline void wait_for_completion_io(struct completion *x)
> +{
> +	complete_acquire(x);
> +	__wait_for_completion_io(x);
> +	complete_release(x);
> +}
> +
> +static inline int wait_for_completion_interruptible(struct completion *x)
> +{
> +	int ret;
> +	complete_acquire(x);
> +	ret = __wait_for_completion_interruptible(x);
> +	complete_release(x);
> +	return ret;
> +}
> +
> +static inline int wait_for_completion_killable(struct completion *x)
> +{
> +	int ret;
> +	complete_acquire(x);
> +	ret = __wait_for_completion_killable(x);
> +	complete_release(x);
> +	return ret;
> +}

I don't understand, why not change __wait_for_common() ?